Skip to content

[release-1.1] rfac: outputAccesslog func to skip accesslog at conn establishment #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kmesh-bot
Copy link
Collaborator

This is an automated cherry-pick of #1376


@hzxuzhonghu
Copy link
Member

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot force-pushed the cherry-pick-1376-to-release-1.1 branch from 240a69f to 263f2cd Compare May 9, 2025 02:58
@kmesh-bot kmesh-bot removed the lgtm label May 9, 2025
@kmesh-bot
Copy link
Collaborator Author

New changes are detected. LGTM label has been removed.

@kmesh-bot kmesh-bot merged commit 62cb154 into kmesh-net:release-1.1 May 9, 2025
9 checks passed
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (c38205e) to head (263f2cd).
Report is 5 commits behind head on release-1.1.

Files with missing lines Patch % Lines
pkg/controller/telemetry/metric.go 14.28% 4 Missing and 2 partials ⚠️
pkg/controller/telemetry/accesslog.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/controller/telemetry/utils.go 69.33% <ø> (ø)
pkg/controller/telemetry/accesslog.go 84.84% <0.00%> (ø)
pkg/controller/telemetry/metric.go 59.45% <14.28%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7500d...263f2cd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants