-
Notifications
You must be signed in to change notification settings - Fork 109
use bytes_acked instead of delivered to get the sent bytes, it is acc… #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…urate Signed-off-by: Zhonghu Xu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an inconsistency in the access log by using tcp_sock->bytes_acked instead of tcp_sock->delivered to determine the sent bytes, ensuring that sent and received bytes are logged consistently.
- Update the metric used for sent bytes in the TCP probe
- Provide a clarifying comment regarding the usage of bytes_acked
/assign @Kuromesi @LiZhenCheng9527 |
@hzxuzhonghu: GitHub didn't allow me to assign the following users: Kuromesi. Note that only kmesh-net members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created: #1392 |
…urate
What type of PR is this?
What this PR does / why we need it:
previously from the access log , we can see the sent_bytes=14566 from one side, but received_bytes=29257 from the other peer, it is totally unconsistent.
With this, now it is consistent.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: