Skip to content

eBPF unit test: Remove expired codes & Add framework doc #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sancppp
Copy link
Contributor

@sancppp sancppp commented May 17, 2025

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1209

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

sancppp added 2 commits May 16, 2025 10:33
Signed-off-by: Zhenxiong Tian <[email protected]>
Signed-off-by: Zhenxiong Tian <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings May 17, 2025 11:32
@kmesh-bot kmesh-bot added the kind/enhancement New feature or request label May 17, 2025
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated eBPF unit test code and adds documentation for the new eBPF unit test framework.

  • Removed several expired test files (xdp_test.c, run_tests.sh, common.h, Makefile)
  • Added comprehensive framework documentation in docs/ebpf_unit_test_zh.md

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/unittest/workload/xdp_test.c Removed expired unit test implementation
test/unittest/workload/run_tests.sh Removed outdated test runner script
test/unittest/workload/common.h Removed unused header definitions and test macros
test/unittest/workload/Makefile Removed obsolete build instructions for unit tests
docs/ebpf_unit_test_zh.md Added documentation outlining the new testing framework
Comments suppressed due to low confidence (2)

docs/ebpf_unit_test_zh.md:1

  • Consider including explicit instructions on how to run the new eBPF unit tests (e.g., command examples or integration details with the CI pipeline) to help users transition from the removed Makefile-based approach.
# Kmesh eBPF 单元测试框架文档

test/unittest/workload/xdp_test.c:1

  • Since the expired test files are being removed, please ensure that any necessary tests have been migrated to the new framework to avoid any gaps in test coverage.
#include <errno.h>

Copy link

codecov bot commented May 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.21%. Comparing base (579f10b) to head (8ec0436).
Report is 38 commits behind head on main.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d11ab...8ec0436. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lfx-mentorship-2025-Mar-May] Kmesh eBPF unit test
2 participants