-
Notifications
You must be signed in to change notification settings - Fork 109
ENH: refactor ctl/docs generation #1425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Scripts for generating kmeshctl documentation are updated to point to the new location of gen.go
under the ctl/doc
directory.
- Changed working directory in the docgen script to match the new
gen.go
location.
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
Signed-off-by: Tom <[email protected]>
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
main
in bothgen.go
andmain.go
, which will cause agopls
problemmain redeclared in this block
.Refactor ctl/docs generation to erase some lint error and add syntax highlight for codeblocks.
Which issue(s) this PR fixes:
Fixes #1264
Special notes for your reviewer:
Does this PR introduce a user-facing change?: