Skip to content

Doc features: Multicluster #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2023
Merged

Doc features: Multicluster #352

merged 4 commits into from
May 8, 2023

Conversation

pushker001
Copy link
Contributor

@pushker001 pushker001 commented May 5, 2023

Helps the user to switch to a different cluster
#255

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:

Helps the user to switch to a different cluster.
Copy link
Collaborator

@undera undera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes:

  1. Crop screenshot, so there's no huge empty space at the bottom. Also, top side of screenshot is cut in the middle of panel & logo. Either make whole panel & logo visible, or crop it off. Generally, when doing screenshot, think that it is meant to help user locate the element that you describe. For that you need to give some context. So it's better to make screenshot with sufficient surrounding. To summarize, this screenshot should contain full top panel, for context.
  2. It's good to add a bit of explanation how this multi-cluster is defined. I mean explaining that the list of clusters comes from kubeconfig. Finding and adding a hyperlink to appropriate k8s doc (https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/ in this case) would let reader to continue learning, if needed.

@undera undera merged commit d225924 into komodorio:main May 8, 2023
@pushker001 pushker001 deleted the doc branch May 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants