Skip to content

WIP: More work on probes, especially on rpmbuild ones #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

jhutar
Copy link
Collaborator

@jhutar jhutar commented May 29, 2025

Description

Changes needed for rpmbuild probe using loadtest and additional improvements and fixes for normal container building probes.

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-7567

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Running it in my fork and besides that I would rely on CI.

jhutar added 29 commits May 23, 2025 09:38
(cherry picked from commit ec8420c)
…e where on missing metric it would say KPI errors = 0
…ips value even when running without --debug or so
…ame namespace which turns out to need to set both new repo Name and Path
…et a change to collect whatever we have so far
…and also it does not make sense to condition fatal message esp. when it also does exit
… repo and will not wait for it to be deleted before forking to it
@openshift-ci openshift-ci bot requested review from dheerajodha and tisutisu May 29, 2025 08:00
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dheerajodha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhutar jhutar force-pushed the fix45-probes branch 2 times, most recently from e7c80d6 to 0c005e9 Compare May 29, 2025 08:28
…s already been taken, The project is still being deleted' even when target repo is already gone (returning 404)
jhutar added 2 commits May 29, 2025 12:14
…crets: Unable to add secret ... to service account ...: serviceaccounts ... not found' errors, so adding explicit step to check component build SA presence
@konflux-ci-qe-bot
Copy link

@jhutar: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-5hb4l Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-5hb4l

Test results analysis

🚨 No JUnit file found, see the log from running tests:

Click to view logs
./mage -v ci:teste2e
Running target: CI:TestE2E
I0602 05:39:20.491574   15670 magefile.go:521] setting up new custom bundle for testing...
Creating Tekton Bundle:
	- Added Pipeline: docker-build to image
I0602 05:39:22.769971   15670 bundle.go:57] image digest for a new tekton bundle quay.io/redhat-appstudio-qe/test-images:pipeline-bundle-1748842761-zgew: quay.io/redhat-appstudio-qe/test-images@sha256:30afbafc57d9dfe5007374fff89508e36441cf56b78108be3c87fa62eb5d64db
I0602 05:39:22.769993   15670 magefile.go:527] To use the custom docker bundle locally, run below cmd:

export CUSTOM_DOCKER_BUILD_PIPELINE_BUNDLE=quay.io/redhat-appstudio-qe/test-images:pipeline-bundle-1748842761-zgew

I0602 05:39:22.770022 15670 e2e_repo.go:347] checking if repository is e2e-tests
I0602 05:39:22.770027 15670 e2e_repo.go:335] multi-platform tests and require sprayproxy registering are set to TRUE
exec: git "diff" "--name-status" "upstream/main..HEAD"
I0602 05:39:22.772950 15670 util.go:454] The following files, pkg/clients/github/repositories.go, pkg/clients/gitlab/git.go, pkg/clients/tekton/pipelineruns.go, tests/load-tests/ci-scripts/collect-results.sh, tests/load-tests/ci-scripts/config/horreum-labels.sh, tests/load-tests/ci-scripts/stage/collect-results.sh, tests/load-tests/ci-scripts/utility_scripts/get-taskruns-durations.py, tests/load-tests/errors.py, tests/load-tests/evaluate.py, tests/load-tests/loadtest.go, tests/load-tests/pkg/journey/handle_component.go, tests/load-tests/pkg/journey/handle_repo_templating.go, tests/load-tests/pkg/journey/handle_test_run.go, tests/load-tests/pkg/logging/logging.go, tests/load-tests/run-max-concurrency.sh, tests/load-tests/run-stage-max-concurrency.sh, tests/load-tests/run-stage.sh, tests/load-tests/run.sh, were changed!
exec: go "install" "-mod=mod" "github.com/onsi/ginkgo/v2/ginkgo"
go: downloading github.com/go-task/slim-sprig/v3 v3.0.0
go: downloading github.com/google/pprof v0.0.0-20240424215950-a892ee059fd6
I0602 05:39:25.717937 15670 install.go:188] cloning 'https://github.com/redhat-appstudio/infra-deployments' with git ref 'refs/heads/main'
Enumerating objects: 54359, done.
Counting objects: 1% (1/88)
Counting objects: 2% (2/88)
Counting objects: 3% (3/88)
Counting objects: 4% (4/88)
Counting objects: 5% (5/88)
Counting objects: 6% (6/88)
Counting objects: 7% (7/88)
Counting objects: 9% (8/88)
Counting objects: 10% (9/88)
Counting objects: 11% (10/88)
Counting objects: 12% (11/88)
Counting objects: 13% (12/88)
Counting objects: 14% (13/88)
Counting objects: 15% (14/88)
Counting objects: 17% (15/88)
Counting objects: 18% (16/88)
Counting objects: 19% (17/88)
Counting objects: 20% (18/88)
Counting objects: 21% (19/88)
Counting objects: 22% (20/88)
Counting objects: 23% (21/88)
Counting objects: 25% (22/88)
Counting objects: 26% (23/88)
Counting objects: 27% (24/88)
Counting objects: 28% (25/88)
Counting objects: 29% (26/88)
Counting objects: 30% (27/88)
Counting objects: 31% (28/88)
Counting objects: 32% (29/88)
Counting objects: 34% (30/88)
Counting objects: 35% (31/88)
Counting objects: 36% (32/88)
Counting objects: 37% (33/88)
Counting objects: 38% (34/88)
Counting objects: 39% (35/88)
Counting objects: 40% (36/88)
Counting objects: 42% (37/88)
Counting objects: 43% (38/88)
Counting objects: 44% (39/88)
Counting objects: 45% (40/88)
Counting objects: 46% (41/88)
Counting objects: 47% (42/88)
Counting objects: 48% (43/88)
Counting objects: 50% (44/88)
Counting objects: 51% (45/88)
Counting objects: 52% (46/88)
Counting objects: 53% (47/88)
Counting objects: 54% (48/88)
Counting objects: 55% (49/88)
Counting objects: 56% (50/88)
Counting objects: 57% (51/88)
Counting objects: 59% (52/88)
Counting objects: 60% (53/88)
Counting objects: 61% (54/88)
Counting objects: 62% (55/88)
Counting objects: 63% (56/88)
Counting objects: 64% (57/88)
Counting objects: 65% (58/88)
Counting objects: 67% (59/88)
Counting objects: 68% (60/88)
Counting objects: 69% (61/88)
Counting objects: 70% (62/88)
Counting objects: 71% (63/88)
Counting objects: 72% (64/88)
Counting objects: 73% (65/88)
Counting objects: 75% (66/88)
Counting objects: 76% (67/88)
Counting objects: 77% (68/88)
Counting objects: 78% (69/88)
Counting objects: 79% (70/88)
Counting objects: 80% (71/88)
Counting objects: 81% (72/88)
Counting objects: 82% (73/88)
Counting objects: 84% (74/88)
Counting objects: 85% (75/88)
Counting objects: 86% (76/88)
Counting objects: 87% (77/88)
Counting objects: 88% (78/88)
Counting objects: 89% (79/88)
Counting objects: 90% (80/88)
Counting objects: 92% (81/88)
Counting objects: 93% (82/88)
Counting objects: 94% (83/88)
Counting objects: 95% (84/88)
Counting objects: 96% (85/88)
Counting objects: 97% (86/88)
Counting objects: 98% (87/88)
Counting objects: 100% (88/88)
Counting objects: 100% (88/88), done.
Compressing objects: 1% (1/52)
Compressing objects: 3% (2/52)
Compressing objects: 5% (3/52)
Compressing objects: 7% (4/52)
Compressing objects: 9% (5/52)
Compressing objects: 11% (6/52)
Compressing objects: 13% (7/52)
Compressing objects: 15% (8/52)
Compressing objects: 17% (9/52)
Compressing objects: 19% (10/52)
Compressing objects: 21% (11/52)
Compressing objects: 23% (12/52)
Compressing objects: 25% (13/52)
Compressing objects: 26% (14/52)
Compressing objects: 28% (15/52)
Compressing objects: 30% (16/52)
Compressing objects: 32% (17/52)
Compressing objects: 34% (18/52)
Compressing objects: 36% (19/52)
Compressing objects: 38% (20/52)
Compressing objects: 40% (21/52)
Compressing objects: 42% (22/52)
Compressing objects: 44% (23/52)
Compressing objects: 46% (24/52)
Compressing objects: 48% (25/52)
Compressing objects: 50% (26/52)
Compressing objects: 51% (27/52)
Compressing objects: 53% (28/52)
Compressing objects: 55% (29/52)
Compressing objects: 57% (30/52)
Compressing objects: 59% (31/52)
Compressing objects: 61% (32/52)
Compressing objects: 63% (33/52)
Compressing objects: 65% (34/52)
Compressing objects: 67% (35/52)
Compressing objects: 69% (36/52)
Compressing objects: 71% (37/52)
Compressing objects: 73% (38/52)
Compressing objects: 75% (39/52)
Compressing objects: 76% (40/52)
Compressing objects: 78% (41/52)
Compressing objects: 80% (42/52)
Compressing objects: 82% (43/52)
Compressing objects: 84% (44/52)
Compressing objects: 86% (45/52)
Compressing objects: 88% (46/52)
Compressing objects: 90% (47/52)
Compressing objects: 92% (48/52)
Compressing objects: 94% (49/52)
Compressing objects: 96% (50/52)
Compressing objects: 98% (51/52)
Compressing objects: 100% (52/52)
Compressing objects: 100% (52/52), done.
Total 54359 (delta 67), reused 36 (delta 36), pack-reused 54271 (from 4)
From https://github.com/redhat-appstudio/infra-deployments

  • branch main -> FETCH_HEAD
    Already up to date.
    Installing the OpenShift GitOps operator subscription:
    clusterrole.rbac.authorization.k8s.io/appstudio-openshift-gitops-argocd-application-controller created
    clusterrole.rbac.authorization.k8s.io/appstudio-openshift-gitops-argocd-server created
    clusterrolebinding.rbac.authorization.k8s.io/appstudio-openshift-gitops-argocd-application-controller created
    clusterrolebinding.rbac.authorization.k8s.io/appstudio-openshift-gitops-argocd-server created
    subscription.operators.coreos.com/openshift-gitops-operator created
    Waiting for default project (and namespace) to exist: ............................................OK
    Waiting for OpenShift GitOps Route: OK
    argocd.argoproj.io/openshift-gitops patched
    argocd.argoproj.io/openshift-gitops patched
    Switch the Route to use re-encryption
    argocd.argoproj.io/openshift-gitops patched
    Restarting ArgoCD Server
    pod "openshift-gitops-server-6984c7fd5c-qd9hf" deleted
    Allow any authenticated users to be admin on the Argo CD instance
    argocd.argoproj.io/openshift-gitops patched
    Mark Pending PVC as Healthy, workaround for WaitForFirstConsumer StorageClasses.
    Warning: unknown field "spec.resourceCustomizations"
    argocd.argoproj.io/openshift-gitops patched (no change)
    Setting kustomize build options
    argocd.argoproj.io/openshift-gitops patched
    Setting ignore Aggregated Roles
    argocd.argoproj.io/openshift-gitops patched
    Setting ArgoCD tracking method to annotation
    argocd.argoproj.io/openshift-gitops patched
    Restarting GitOps server
    deployment.apps/openshift-gitops-server restarted

=========================================================================

Argo CD URL is: https://openshift-gitops-server-openshift-gitops.apps.rosa.kx-1a3b60b374.5beq.p3.openshiftapps.com

(NOTE: It may take a few moments for the route to become available)

Waiting for the route: .OK

Login/password uses your OpenShift credentials ('Login with OpenShift' button)
Setting secrets for Quality Dashboard
namespace/quality-dashboard created
secret/quality-dashboard-secrets created
Creating secret for CI Helper App
namespace/ci-helper-app created
secret/ci-helper-app-secrets created
[WARN] Namespace 'image-controller' does not exist. Creating it...
namespace/image-controller created
secret/sealights-token created
[INFO] Secret 'sealights-token' has been created/updated in namespace 'image-controller'.
[WARN] Namespace 'integration-service' does not exist. Creating it...
namespace/integration-service created
secret/sealights-token created
[INFO] Secret 'sealights-token' has been created/updated in namespace 'integration-service'.
[WARN] Namespace 'release-service' does not exist. Creating it...
namespace/release-service created
secret/sealights-token created
[INFO] Secret 'sealights-token' has been created/updated in namespace 'release-service'.
[WARN] Namespace 'build-service' does not exist. Creating it...
namespace/build-service created
secret/sealights-token created
[INFO] Secret 'sealights-token' has been created/updated in namespace 'build-service'.
Setting secrets for pipeline-service
tekton-results namespace already exists, skipping creatio... the content is too long - please download the artifact to see the full content


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants