Skip to content

Add set-default-label function #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jul 23, 2022

This PR adds a new set-default-labels function, based on the set-label transformer. It adds the recommended labels to follow the kpt label conventions.

Right now we only add app-name label, which uses the value from the root Kptfile name. This convention believes that all KRM resources under the same kpt package should be served for a specific application.

An application (or KPT package) can be composed by other applications (nested sub KPT packages).
So the function can accept multiple Kptfile and use the root Kptfile to set the app name.

@yuwenma yuwenma force-pushed the set-default-label branch 3 times, most recently from 0063969 to 6cd9b92 Compare July 25, 2022 17:33
@yuwenma yuwenma force-pushed the set-default-label branch from 6cd9b92 to 51df837 Compare July 25, 2022 23:44
@yuwenma
Copy link
Contributor Author

yuwenma commented Jul 25, 2022

@mengqiy Thank you! Ready for another look.

@yuwenma yuwenma force-pushed the set-default-label branch from 51df837 to bd9b765 Compare July 26, 2022 00:21
@yuwenma yuwenma force-pushed the set-default-label branch 2 times, most recently from 9cccffc to 2f5508a Compare July 26, 2022 18:55
Copy link
Contributor

@mengqiy mengqiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you checked in a binary: scripts/patch_reader/patch_reader.
Please revert it.

@yuwenma
Copy link
Contributor Author

yuwenma commented Jul 28, 2022

This PR is waiting for some user message improvements from its dependent set-labels module.

@yuwenma yuwenma force-pushed the set-default-label branch from 2f5508a to 04f3e9b Compare July 28, 2022 23:42
@yuwenma
Copy link
Contributor Author

yuwenma commented Jul 28, 2022

It seems you checked in a binary: scripts/patch_reader/patch_reader. Please revert it.

😆 my local branch has a different name (I rarely use different branch names) and obviously I forgot that after working on other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants