-
Notifications
You must be signed in to change notification settings - Fork 72
Add set-default-label
function
#890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0063969
to
6cd9b92
Compare
examples/set-default-labels-nested-package/app1_ghost/resources.yaml
Outdated
Show resolved
Hide resolved
examples/set-default-labels-nested-package/app2_mysql/README.md
Outdated
Show resolved
Hide resolved
examples/set-default-labels-nested-package/app2_mysql/README.md
Outdated
Show resolved
Hide resolved
6cd9b92
to
51df837
Compare
@mengqiy Thank you! Ready for another look. |
51df837
to
bd9b765
Compare
9cccffc
to
2f5508a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you checked in a binary: scripts/patch_reader/patch_reader
.
Please revert it.
This PR is waiting for some user message improvements from its dependent
|
2f5508a
to
04f3e9b
Compare
😆 my local branch has a different name (I rarely use different branch names) and obviously I forgot that after working on other stuff. |
This PR adds a new set-default-labels function, based on the set-label transformer. It adds the recommended labels to follow the kpt label conventions.
Right now we only add app-name label, which uses the value from the root
Kptfile
name. This convention believes that all KRM resources under the same kpt package should be served for a specific application.An application (or KPT package) can be composed by other applications (nested sub KPT packages).
So the function can accept multiple Kptfile and use the root Kptfile to set the app name.