fix: set-image with more matching rules
#909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy98
requested review from
droot,
mengqiy,
sdowell and
yuwenma
as code owners
yuwenma
reviewed
Aug 31, 2022
yuwenma
reviewed
Aug 31, 2022
yuwenma
reviewed
Aug 31, 2022
yuwenma
reviewed
Aug 31, 2022
yuwenma
reviewed
Aug 31, 2022
yuwenma
reviewed
Aug 31, 2022
Comment on lines
+201
to
210
| // getContainers gets the containers inside kubeObject | ||
| func getContainers(o *fn.KubeObject) fn.SliceSubObjects { | ||
| switch o.GetKind() { | ||
| case "Pod": | ||
| return getPodContainers(o) | ||
| case "Deployment", "StatefulSet", "ReplicaSet", "DaemonSet", "PodTemplate": | ||
| return getPodSpecContainers(o) | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
suggest adding it back to the main Run method. This part belongs to the main logic so it's better to be replaced in the main function
There was a problem hiding this comment.
Run method already uses this function getContianers, I have this as a separate function because I feel I need to iterate containers twice, once for validating user input if image name is not provided, once for update container images. To reduce code duplication, I have this function here.
yuwenma
reviewed
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix issue kptdev/kpt#3444
provide
containerNameandimageNameas input, supportcontainerNamematching, supportimageNameomission inside input