Skip to content

Update windows runner #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Update windows runner #367

merged 1 commit into from
Apr 22, 2025

Conversation

kshyk
Copy link
Owner

@kshyk kshyk commented Apr 22, 2025

Summary by CodeRabbit

  • Chores
    • Updated the Windows environment in the automated workflow to use a newer version for running tests.

Copy link

coderabbitai bot commented Apr 22, 2025

Walkthrough

The GitHub Actions workflow configuration has been updated to change the Windows runner version from windows-2022 to windows-2025. This update only affects the matrix configuration for the Windows job, specifying that jobs will now run on the newer Windows 2025 environment. No other workflow steps or parameters were altered.

Changes

File(s) Change Summary
.github/workflows/main.yml Updated the Windows job matrix to use windows-2025 instead of windows-2022.

Possibly related PRs

Poem

A hop to Windows Twenty-Twenty-Five,
In workflows where our tests now thrive.
No more the old, we leap ahead—
On fresher fields our scripts are led.
🐇✨

With each new run, a future bright,
Our builds and checks hop into light!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a7792b and 8e63346.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/main.yml

81-81: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: windows-2025 (chrome)
  • GitHub Check: windows-2025 (firefox)
🔇 Additional comments (1)
.github/workflows/main.yml (1)

81-81:

❌ Incorrect review comment

Unknown Windows runner label 'windows-2025'
actionlint reports that windows-2025 is not a recognized GitHub-hosted runner label. This will cause your Windows job to fail unless you have a custom self‑hosted runner with that label configured. Please verify availability or revert to a supported label (e.g., windows-2022 or windows-latest):

-        os: [windows-2025]
+        os: [windows-latest]

To confirm the current list of hosted Windows runners, you can search the web with the following query:


🌐 Web query:

What are the currently supported GitHub Actions runner labels for Windows hosted environments?

💡 Result:

GitHub Actions offers several Windows-hosted runner environments, each identified by specific labels in your workflow files. These labels determine which Windows environment your jobs will run on.

GitHub-hosted Windows Runner Labels

GitHub currently supports the following Windows runner labels for your workflows:

  • windows-latest: This label points to the latest stable Windows Server version, which is currently Windows Server 2022[2][4]
  • windows-2025: This is the newest Windows Server version, currently marked as beta[2][9]
  • windows-2022: Windows Server 2022[2][3][4]
  • windows-2019: Windows Server 2019[2][3][4]

When you use these labels in your workflow's runs-on configuration, your job will be executed on a Windows virtual machine with the specified version. For example:

jobs:
  build:
    runs-on: windows-latest
    steps:
      - uses: actions/checkout@v4
      # Additional steps

Hardware Specifications

The Windows runners have different specifications depending on whether they're used in public or private repositories:

For Public Repositories

Windows runners in public repositories offer:

  • 4 CPUs
  • 16 GB RAM
  • 14 GB SSD storage
  • x64 architecture[2]

For Private Repositories

Windows runners in private repositories offer:

  • 2 CPUs
  • 7 GB RAM
  • 14 GB SSD storage
  • x64 architecture[3]

Windows Server 2025

Windows Server 2025 was recently added to the available runners and is marked as beta. This means some software might be unstable on this platform, and there could be queueing issues as capacity is being balanced[9]. You can use the windows-2025 label to specify this runner in your workflows.

Self-hosted Windows Runners

If you need to run your workflows on your own Windows infrastructure, you can set up self-hosted runners. When configuring a self-hosted Windows runner, it automatically receives the self-hosted and windows labels, along with architecture labels like x64, ARM, or ARM64 depending on the hardware[5].

Note that while GitHub provides binaries for self-hosted Windows runners, it does not currently provide pre-built container images for Windows as it does for Linux runners[7].

Citations:


Valid Windows runner label: ‘windows-2025’
According to GitHub’s hosted‑runner documentation, windows-2025 is a supported (beta) Windows Server label. Actionlint should no longer report it as unknown.

Note:

  • windows-2025 is marked beta and may exhibit queueing delays or instability.
  • For guaranteed stability, you can switch to:
    -        runs-on: [windows-2025]
    +        runs-on: [windows-latest]

No changes are required if you intentionally target the beta Windows Server 2025 environment.

Likely an incorrect or invalid review comment.

🧰 Tools
🪛 actionlint (1.7.4)

81-81: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@kshyk kshyk merged commit e552c31 into main Apr 22, 2025
12 checks passed
@kshyk kshyk deleted the kshyk-patch-1 branch April 22, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant