Add missing query parameters to GetDiff #291
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added the additional fields:
to GetDiff.
Justified by the documentation page, and adding
from_pullrequest_id
as it appears inpullRequest.Links.Diff.Href
:When using GetDiff with
from_pullrequest_id
(as also happens with GetDiffStat) the SPEC would follow the format:REPO_SLUG:hash
.NOTE: I am aware that the
DiffOptions
type is also used as a parameter to GetPatch, which does not seem to support all these query parameters. I was tempted to create a new type:but replacing the current parameter in
GetPatch
with this new type would break backwards compatibility with any current consumers of this library.So I just mention it in case you want to do that separately in a future version change ;)