Skip to content

Automated cherry pick of #2079: fix volcano podgroup update issue #2130: Refine the integration tests for the immutable PyTorchJob #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Automated cherry pick of #2079: fix volcano podgroup update issue #2130: Refine the integration tests for the immutable PyTorchJob #2139

merged 1 commit into from
Jun 10, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jun 7, 2024

Cherry pick of #2079 #2130 on v1.8-branch.
#2079: fix volcano podgroup update issue
#2130: Refine the integration tests for the immutable PyTorchJob

I manually squashed commits and modified signs since @ckyuto signed to DCO and CLA with different email addresses.

Commit sha: 18844bd, Author: Weiyu Yen, Committer: Yuki Iwai; Expected "Weiyu Yen [email protected]", but got "Weiyu Yen [email protected]".

https://github.com/kubeflow/training-operator/pull/2134/checks?check_run_id=25949083128

Signed-off-by: Yuki Iwai <[email protected]>
Co-authored-by: WEI-YU YEN <[email protected]>
@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9419698397

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 35.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/job.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 8869266420: 0.03%
Covered Lines: 4379
Relevant Lines: 12365

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9419796281

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 35.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/common/job.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 8869266420: 0.03%
Covered Lines: 4379
Relevant Lines: 12365

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tenzen-y!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 498e66e into kubeflow:v1.8-branch Jun 10, 2024
39 checks passed
@tenzen-y tenzen-y deleted the automated-cherry-pick-of-#2079-#2130-upstream-v1.8-branch branch June 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants