Consider using SocketsHttpHandler

[qmfrederik]

See #129 for details, but custom/client certificate handling on macOS seems to be broken unless using the SocketsHttpHandler.

In .NET Core 2.1 Preview 1, you can enable this using an environment variable. In Preview 2, you should be able to control this in code by running:

new HttpClient(new SocketsHttpHandler())

This issue is to track us making that change when .NET Core 2.1 Preview 2 ships.

[tintoy]

Yep same goes for our WebSockets connection builder :)

[tintoy]

Now that the preview2 SDK is available, I'll open a PR to switch the Travis build over to using it :)

[tintoy]

If we want to start cleaning up the hacky code for the WebSocket client, we need the new SocketsHttpHandler from preview 2, but...

@brendanburns - the .NET Core packages for Debian / Ubuntu are broken for preview 2.

I got this going in my other project by installing from tarball instead (tintoy/dotnet-kube-client@66c27cf), are you OK with me taking the same approach here? We could always wait for new packages but it looks like they've been broken for a while and may not be fixed until after preview 2.

[brendandburns]

@tintoy I assume that the .NET core packages are fixed now that 2.1 final has released. Are we ready to start moving?

[tintoy]

Yep! Will have a go at this tomorrow morning (it's Saturday afternoon here ATM)

[tintoy]

@brendandburns - sorry have been flat out at work (new job) but will have time to do this first thing tomorrow :)

[brendandburns]

No worries, want help? I'm happy to pitch in some code and split the work if you want...

…

--brendan

________________________________ From: Adam Friedman <notifications@github.com> Sent: Tuesday, June 5, 2018 11:39:22 AM To: kubernetes-client/csharp Cc: Brendan Burns; Mention Subject: Re: [kubernetes-client/csharp] Consider using SocketsHttpHandler (#130) @brendandburns<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrendandburns&data=02%7C01%7Cbburns%40microsoft.com%7C2ffa758afd224527e73c08d5cb13a89b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636638207644523513&sdata=Cp1zsgEvzZAJ1O3%2BH2K3mTGlpcpTl3CkMYbJ2iZNEyU%3D&reserved=0> - sorry have been flat out at work (new job) but will have time to do this first thing tomorrow :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes-client%2Fcsharp%2Fissues%2F130%23issuecomment-394816528&data=02%7C01%7Cbburns%40microsoft.com%7C2ffa758afd224527e73c08d5cb13a89b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636638207644523513&sdata=o5LLENVUukBNeaNwsZfU8vj%2BDY5XhdwiRk9sja7M%2BqA%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDgvjCK4WTYavT_ajKtsc6o406Cqmlks5t5tBagaJpZM4TBuL7&data=02%7C01%7Cbburns%40microsoft.com%7C2ffa758afd224527e73c08d5cb13a89b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636638207644533534&sdata=94fsgIk25NVWVkuwacXC9n4QSQQ3RMxmsAO2jLcel28%3D&reserved=0>.

[tintoy]

Thanks! I think I'm OK for now - it's not a large piece of work (less than an hour), just haven't had time to do it yet. If I run into any difficulties tomorrow though I'll be putting my hand up :)

[brendandburns]

SGTM thanks

…

--brendan

________________________________ From: Adam Friedman <notifications@github.com> Sent: Tuesday, June 5, 2018 4:39:14 PM To: kubernetes-client/csharp Cc: Brendan Burns; Mention Subject: Re: [kubernetes-client/csharp] Consider using SocketsHttpHandler (#130) Thanks! I think I'm OK for now - it's not a large piece of work (less than an hour), just haven't had time to do it yet. If I run into any difficulties tomorrow though I'll be putting my hand up :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes-client%2Fcsharp%2Fissues%2F130%23issuecomment-394894228&data=02%7C01%7Cbburns%40microsoft.com%7C35c7df298ab64bcbefa308d5cb3d8c27%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636638387557644630&sdata=sPw5xlBHyYCKbLClBg4R7iZNUwebVIcGkBVFmB4P%2BGY%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDglwhJDfEWHG63epNP5dU4FGiMjy_ks5t5xaigaJpZM4TBuL7&data=02%7C01%7Cbburns%40microsoft.com%7C35c7df298ab64bcbefa308d5cb3d8c27%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636638387557644630&sdata=fIzBnFEKbVt9mOWl%2BfdBK%2F06Hz6kYJmmd60542ckdf0%3D&reserved=0>.

[tintoy]

Ok - working on this now.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale