Skip to content

Add AddJsonOptions to KubernetesClientConfiguration and KubernetesJson #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Apr 4, 2023
Merged

Add AddJsonOptions to KubernetesClientConfiguration and KubernetesJson #1257

merged 22 commits into from
Apr 4, 2023

Conversation

luiscantero
Copy link
Contributor

  • Add AddJsonOptions so that JsonSerializerOptions can be customized
  • Add unit test for JSON serialization

luiscantero and others added 19 commits February 17, 2023 21:33
@luiscantero
Use camelCase policy when serializing enums
467f49d
@luiscantero
Merge branch 'kubernetes-client:master' into master
62959fc
@luiscantero
Revert "Use camelCase policy when serializing enums"
e16df9e 
This reverts commit 467f49d.
@luiscantero
Add jonSerializerOptions to GenericClient
59c3c73
@luiscantero
Add jsonSerializerOptions param
bf6d7a6
@luiscantero
Revert pass deserialization options in GenericClient
e46c60e
@luiscantero
Add JsonSerializerOptions to KubernetesClientConfiguration
ecd46a8
@luiscantero
Use user JsonSerializerOptions in SendRequest and CreateResultAsync
568534a
@luiscantero
Improve comment
47f3787
@luiscantero
Remove JsonSerializerOptions
72dc77a
@luiscantero
Cosmetic
f21e587
@luiscantero
Add AddJsonOptions
277e788
@luiscantero
Fix example
47662cc
@luiscantero
Fix test
65a35a9
@luiscantero
Add test
a7824f7
@luiscantero
Add summary
0218aae
@luiscantero
Improve summary
706d9c4
@luiscantero
Remove configure from Kubernetes ctor and tests
e2a24ca
@luiscantero
Add AddJsonOptions to config and test
80083a7
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2023
tg123
tg123 reviewed Apr 3, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2023
@tg123
Copy link
Member

tg123 commented Apr 4, 2023

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@aa84b45). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1257   +/-   ##
=========================================
  Coverage          ?   69.93%           
=========================================
  Files             ?       95           
  Lines             ?     2691           
  Branches          ?        0           
=========================================
  Hits              ?     1882           
  Misses            ?      809           
  Partials          ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@luiscantero
Copy link
Contributor Author

Pushed fix for CodeQL issues

tg123
tg123 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@tg123 tg123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luiscantero, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2af57ca into kubernetes-client:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@tg123 tg123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luiscantero @tg123 @codecov-commenter @k8s-ci-robot