Skip to content

feat: switch JsonConverters to public for Source Generators #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/KubernetesClient.Models/ResourceQuantityJsonConverter.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
namespace k8s.Models
{
public sealed class ResourceQuantityJsonConverter : JsonConverter<ResourceQuantity>
{
public override ResourceQuantity Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
return new ResourceQuantity(reader.GetString());
}

public override void Write(Utf8JsonWriter writer, ResourceQuantity value, JsonSerializerOptions options)
{
if (writer == null)
{
throw new ArgumentNullException(nameof(writer));
}

writer.WriteStringValue(value?.ToString());
}
}
}
6 changes: 3 additions & 3 deletions src/KubernetesClient/KubernetesJson.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public static class KubernetesJson
{
private static readonly JsonSerializerOptions JsonSerializerOptions = new JsonSerializerOptions();

private sealed class Iso8601TimeSpanConverter : JsonConverter<TimeSpan>
public sealed class Iso8601TimeSpanConverter : JsonConverter<TimeSpan>
{
public override TimeSpan Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Expand All @@ -23,7 +23,7 @@ public override void Write(Utf8JsonWriter writer, TimeSpan value, JsonSerializer
}
}

private sealed class KubernetesDateTimeOffsetConverter : JsonConverter<DateTimeOffset>
public sealed class KubernetesDateTimeOffsetConverter : JsonConverter<DateTimeOffset>
{
private const string RFC3339MicroFormat = "yyyy'-'MM'-'dd'T'HH':'mm':'ss.ffffffK";
private const string RFC3339NanoFormat = "yyyy-MM-dd'T'HH':'mm':'ss.fffffffK";
Expand Down Expand Up @@ -55,7 +55,7 @@ public override void Write(Utf8JsonWriter writer, DateTimeOffset value, JsonSeri
}
}

private sealed class KubernetesDateTimeConverter : JsonConverter<DateTime>
public sealed class KubernetesDateTimeConverter : JsonConverter<DateTime>
{
private static readonly JsonConverter<DateTimeOffset> UtcConverter = new KubernetesDateTimeOffsetConverter();
public override DateTime Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
Expand Down
2 changes: 1 addition & 1 deletion src/KubernetesClient/Models/IntOrStringJsonConverter.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace k8s.Models
{
internal sealed class IntOrStringJsonConverter : JsonConverter<IntstrIntOrString>
public sealed class IntOrStringJsonConverter : JsonConverter<IntstrIntOrString>
{
public override IntstrIntOrString Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Expand Down
2 changes: 1 addition & 1 deletion src/KubernetesClient/Models/V1PatchJsonConverter.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace k8s.Models
{
internal sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
public sealed class V1PatchJsonConverter : JsonConverter<V1Patch>
{
public override V1Patch Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Expand Down
2 changes: 1 addition & 1 deletion src/KubernetesClient/Models/V1Status.ObjectView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ namespace k8s.Models
{
public partial class V1Status
{
internal sealed class V1StatusObjectViewConverter : JsonConverter<V1Status>
public sealed class V1StatusObjectViewConverter : JsonConverter<V1Status>
{
public override V1Status Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
{
Expand Down