Skip to content

feat: allow overriding YamlDotNet settings #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/KubernetesClient/KubernetesYaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ public static class KubernetesYaml
.WithTypeConverter(new ByteArrayStringYamlConverter())
.WithTypeConverter(new ResourceQuantityYamlConverter())
.WithAttemptingUnquotedStringTypeDeserialization()
.WithOverridesFromJsonPropertyAttributes();
.WithOverridesFromJsonPropertyAttributes()
.ExecuteDeserializerEvent();

private static readonly IDeserializer StrictDeserializer =
CommonDeserializerBuilder
Expand All @@ -42,8 +43,19 @@ public static class KubernetesYaml
.WithEventEmitter(e => new FloatEmitter(e))
.ConfigureDefaultValuesHandling(DefaultValuesHandling.OmitNull)
.WithOverridesFromJsonPropertyAttributes()
.ExecuteSerializerEvent()
.BuildValueSerializer();

private static DeserializerBuilder ExecuteDeserializerEvent(this DeserializerBuilder builder)
{
return KubernetesYamlConfiguration.ExecuteDeserializerOptions(builder);
}

private static SerializerBuilder ExecuteSerializerEvent(this SerializerBuilder builder)
{
return KubernetesYamlConfiguration.ExecuteSerializerOptions(builder);
}

private static readonly IDictionary<string, Type> ModelTypeMap = typeof(KubernetesEntityAttribute).Assembly
.GetTypes()
.Where(t => t.GetCustomAttributes(typeof(KubernetesEntityAttribute), true).Any())
Expand Down
34 changes: 34 additions & 0 deletions src/KubernetesClient/KubernetesYamlConfiguration.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
using YamlDotNet.Serialization;

namespace k8s
{
/// <summary>
/// This class allows overriding the <see cref="YamlDotNet"/> settings.
/// </summary>
public static class KubernetesYamlConfiguration
{
/// <summary>
/// Configures <see cref="DeserializerBuilder"/> for <see cref="YamlDotNet"/>.
/// </summary>
public static event EventHandler<DeserializerBuilder> DeseralizerEvent;

/// <summary>
/// Configures <see cref="SerializerBuilder"/> for <see cref="YamlDotNet"/>.
/// </summary>
public static event EventHandler<SerializerBuilder> SeralizerEvent;

internal static SerializerBuilder ExecuteSerializerOptions(SerializerBuilder builder)
{
SeralizerEvent?.Invoke(null, builder);

return builder;
}

internal static DeserializerBuilder ExecuteDeserializerOptions(DeserializerBuilder builder)
{
DeseralizerEvent?.Invoke(null, builder);

return builder;
}
}
}