Improve docs and naming of LeaderElector methods.
#1468
Merged
+39
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
tg123
reviewed
Dec 6, 2023
PSanetra
force-pushed
the
improve-LeaderElector-docs
branch
from
585c900 to
09fd080
Compare
…eaderElector.RunAndTryToHoldLeadershipForeverAsync()`
PSanetra
force-pushed
the
improve-LeaderElector-docs
branch
from
09fd080 to
a023aba
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PSanetra, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tg123
reviewed
Dec 6, 2023
k8s-ci-robot
removed
the
lgtm
|
/LGTM |
k8s-ci-robot
added
the
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
=========================================
Coverage ? 70.47%
=========================================
Files ? 89
Lines ? 2655
Branches ? 554
=========================================
Hits ? 1871
Misses ? 784
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves docs and naming of
LeaderElectormethods. Also introducesLeaderElector.AcquireLeadershipForever().Fixes #1467