-
Notifications
You must be signed in to change notification settings - Fork 305
Improve docs and naming of LeaderElector
methods.
#1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs and naming of LeaderElector
methods.
#1468
Conversation
585c900
to
09fd080
Compare
…eaderElector.RunAndTryToHoldLeadershipForeverAsync()`
09fd080
to
a023aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PSanetra, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
=========================================
Coverage ? 70.47%
=========================================
Files ? 89
Lines ? 2655
Branches ? 554
=========================================
Hits ? 1871
Misses ? 784
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Improves docs and naming of
LeaderElector
methods. Also introducesLeaderElector.AcquireLeadershipForever()
.Fixes #1467