-
Notifications
You must be signed in to change notification settings - Fork 305
Clean up warnings in examples #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up warnings in the sample projects by removing unnecessary namespace and class wrappers and leveraging top‑level statements and new language features.
- Removed redundant using directives and async Main methods.
- Updated comments and documentation parameters.
- Adopted modern C# patterns for top‑level statements across multiple examples.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
examples/yaml/Program.cs | Removed threading-related using and wrapper class/namespace for top‑level code. |
examples/webApiDependencyInjection/Controllers/ExampleDependencyInjectionOnMethodController.cs | Improved XML comments and added null-check with ArgumentNullException.ThrowIfNull. |
examples/webApiDependencyInjection/Controllers/ExampleDependencyInjectionOnConstructorController.cs | Updated documentation and refined the method signature for clarity. |
examples/watch/Program.cs | Converted callback method into a top‑level function with updated warning suppression. |
examples/simple/PodList.cs | Refactored from namespace encapsulation to top‑level code. |
examples/portforward/PortForward.cs | Converted the Forward method to a top‑level async function. |
examples/patch/Program.cs | Removed namespace/class wrappers, updated PrintLabels to a top‑level function. |
examples/namespace/NamespaceExample.cs | Eliminated namespace declaration to allow top‑level function definitions. |
examples/metrics/Program.cs | Converted multiple async methods to top‑level functions. |
examples/logs/Logs.cs | Removed namespace and async Task structure in favor of top‑level statements. |
examples/labels/PodList.cs | Simplified structure by removing redundant namespace/class wrappers. |
examples/generic/Generic.cs | Refactored out of namespace for top-level code style. |
examples/exec/Exec.cs | Converted methods to top-level functions while retaining async invocation. |
examples/csrApproval/Program.cs | Updated the X509EnhancedKeyUsageExtension initializer to utilize new syntax. |
examples/attach/Attach.cs | Changed AttachToPod to a top-level async function format. |
Files not reviewed (1)
- Directory.Build.props: Language not supported
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ae79be6
into
kubernetes-client:master
No description provided.