Extra tests for the Watcher classes #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
LGTM, thank you! |
JonJam
pushed a commit
to JonJam/csharp
that referenced
this pull request
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new tests
WatchEventsWithTimeout, which mimicsWatchEventsbut adds a delay of 120 seconds between 2 watch events. The default timeout of the HttpClient is 100 seconds, and this test servers to make sure the HttpClient doesn't choke on the 2 minutes without any eventsDirectWatchAllEventswhich is similar toWatchAllEvents, but directly uses theKubernetes.Watch*APIDirectWatchAllEventsWithTimeoutwhich mimics a scenario in which you initiate a watch, but no events are sent in the first 100 seconds. In this scenario, the client times out. The test is disabled because this bug has not been fixed (see Watchers time out after 100 seconds #165).