Watcher: notify the caller when the server closes the connection #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Looks reasonable but the unit tests are hanging on Travis for some reason... |
- Run Task.Yield at the beginning to make sure we're running async - Set Watching = false before invoking OnClosed, to make sure the callers see a consistent state.
|
Yeah, should be fixed now. The start of |
|
LGTM. |
JonJam
pushed a commit
to JonJam/csharp
that referenced
this pull request
Sep 8, 2018
…ernetes-client#184) * Watcher: Add onClosed event and callback * Update the code generators to accept the onClose callback * Re-generate API * Update unit tests * Fix unit test * Watcher fixes/improvements: - Run Task.Yield at the beginning to make sure we're running async - Set Watching = false before invoking OnClosed, to make sure the callers see a consistent state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes server can close the connection on any watch call. There's a default timeout of 30-60 minutes, though you can specify a custom timeout when you use the
timeoutSecondsparameter.Let the consumer of the
Watcher<T>class know when the server closed the connection, by raising theClosedevent or invoking theonClosedcallback.Also regenerates the API and updates the unit tests, so this may best be reviewed on a per-commit basis.
Fixes #181, #165