Skip to content

generate for 1.13 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2018
Merged

generate for 1.13 #223

merged 3 commits into from
Dec 12, 2018

Conversation

tg123
Copy link
Member

@tg123 tg123 commented Dec 7, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 7, 2018
@brendandburns
Copy link
Contributor

Thanks! Can you squash this down into two commits:

  1. new API changes
  2. fixes to examples, etc.

Thanks!

@tg123
Copy link
Member Author

tg123 commented Dec 10, 2018

done
another commit is for updating the cert used in test

@brendandburns
Copy link
Contributor

Let's rev the version to 1.4 with this also.

@tg123
Copy link
Member Author

tg123 commented Dec 11, 2018

@brendandburns already bumped up to 1.4

  -"version": "1.3",
  +"version": "1.4",

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tg123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1600e44 into kubernetes-client:master Dec 12, 2018
@tg123 tg123 deleted the 1.13 branch February 5, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants