-
Notifications
You must be signed in to change notification settings - Fork 305
Bump down Newtonsoft.Json package to 9.0.1 from 10.0.2. Add reference… #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump down Newtonsoft.Json package to 9.0.1 from 10.0.2. Add reference… #230
Conversation
… to System.ComponentModel.TypeConverter to fix build.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @brendandburns |
@pragyamehta Why is this needed? Thanks |
I signed it |
This is needed to temporarily resolve some issues with version conflicts between AutoRest and our use of NewtonSoft. AutoRest is tracking fixes so that we can re-fix the dependencies here. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, pragyamehta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sorry I am not quite clear about the fix. |
… to System.ComponentModel.TypeConverter to fix build.