Skip to content

Fix NuGet package versions #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix NuGet package versions #257

merged 1 commit into from
Mar 20, 2019

Conversation

qmfrederik
Copy link
Contributor

The version numbers of the NuGet packages which are pushed to nuget.org currently include the Git commit ID as a suffix (e.g. 1.5.1-g60ffd20a7c).

This causes NuGet to mark those packages as prerelease, and as a result most people stick to the 1.2.0 version, which is about 8 months old.

NB.GV drops the build suffix when building from master (as specified in version.json). Because Travis checks out the commits in a detached head state, NB.GV doesn't detect this and adds the suffix anyway.

NB.GV detects 'cloud build services' using environment variables, but doesn't have built in support for Travis (yet, see dotnet/Nerdbank.GitVersioning#310).

As a workaround, set the environment variables used by other cloud build services.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2019
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, qmfrederik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit a0ab45a into kubernetes-client:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants