Fix build warnings in the StreamDemuxerTests #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StreamDemuxerTests
were causing build warnings like this:This was cause by this line:
which creates a background task but never
await
s it.StreamDemuxer.Start
should return immediately, but it was possible for that call to block. I've fixed that.I've also found an issue in the
ReceiveAsync
method of theMockWebSocket
class, where it didn't honor theCancellationToken
, and fixed that as well.