Skip to content

Add MSBuild leg, for building NuGet package with Xamarin support #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Add MSBuild leg, for building NuGet package with Xamarin support #266

merged 1 commit into from
Mar 22, 2019

Conversation

qmfrederik
Copy link
Contributor

This PR adds another build leg to the Azure pipline, which uses MSBuild.exe instead of dotnet.exe to build the KubernetesClient. This way, you can build a NuGet package with Xamarin support, too.

It also:

  • Adds a netstandard2.0 and net461 target. This puts the package in line with the Open Source Library Guidance, although they also recommend dropping netstandard1.x and net452 alltogether.
  • Disables cross-building for Xamarin alltogether when building using dotnet build.
  • Removes redundant dependencies for the netstandard/netcoreapp targets

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2019
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, qmfrederik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6b12a11 into kubernetes-client:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants