Skip to content

WIP - Re-enable Ubuntu build in CI #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

WIP - Re-enable Ubuntu build in CI #284

wants to merge 9 commits into from

Conversation

tomkerkhove
Copy link
Contributor

Re-enable Ubuntu build in CI

Follow-up of #283

Re-enable Ubuntu build in CI

Follow-up of #283
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tomkerkhove
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: brendandburns

If they are not already assigned, you can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2019
@tomkerkhove
Copy link
Contributor Author

/assign @brendandburns

@tomkerkhove
Copy link
Contributor Author

tomkerkhove commented May 13, 2019

Looks like the build is hanging because of minikube which is the same issue from original CI.
Figured this was going to be fixed with the revving but guess not.

An additional improvement would be not to wait for the cluster if Minikube has crashed:
https://github.com/kubernetes-client/csharp/blob/master/install-linux.sh#L29

@tomkerkhove
Copy link
Contributor Author

tomkerkhove commented May 13, 2019

I've added logs for tracing what version for kubectl & minikube is being installed, but they don't always show up somehow.

That said, I've changed minikube commands to use --logtostderr so that we see what is wrong.

Turns out we have a couple of issues:

  • unsupported docker version: 3.0.4
  • Error reading config file at /home/vsts/.minikube/config/config.json: open /home/vsts/.minikube/config/config.json: no such file or directory - Although this can be side-effect, but not sure

@qmfrederik
Copy link
Contributor

@tomkerkhove That's odd, perhaps you can add a docker -v to see what version of Docker is installed. Kubernetes is a bit picky with which version of Docker it supports - the supported versions now are 1.13.1, 17.03, 17.06, 17.09, 18.06, 18.09.

Azure DevOps regularly upgrades the software installed on the agents, which can cause sudden build breaks like this. (Travis is much more conservative in that respect)

@tomkerkhove
Copy link
Contributor Author

I'll add the docker version to the output and make sure we install a specific version so that we run the correct version if we can.

Looks like they've changed it recently: microsoft/azure-pipelines-image-generation@8e6db92#diff-f87405c9dd43f633a04dd078666d61af

@qmfrederik
Copy link
Contributor

Yeah, so that means we'll probably need some packaging voodoo to uninstall the version of Docker that comes pre-installed, and replace it with a version which is supported by Kubernetes.

@tomkerkhove
Copy link
Contributor Author

Not really, they actually have it out of the box - https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/docker-installer?view=azure-devops

Will update the PR in a few hours

@tomkerkhove tomkerkhove changed the title Re-enable Ubuntu build in CI WIP - Re-enable Ubuntu build in CI May 13, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2019
Use Docker 17.09.0-ce which actually exists and allows older version to be verified as well
@tomkerkhove
Copy link
Contributor Author

I'll abandon this PR for now and circle back once I get this working.

Don't want to burn too much build time/spam people

@tomkerkhove
Copy link
Contributor Author

Not really, they actually have it out of the box - https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/docker-installer?view=azure-devops

Nevermind, this is just the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants