Add another couple of constructors to Fix #279

[DavidParks8]

This change deduplicates some of the code of the Kubernetes class, and adds the ability to use KubernetesClientConfiguration with the http client factory pattern.

A sample project was added to show how this pattern might be used.

[k8s-ci-robot]

Welcome @DavidParks8!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[DavidParks8]

Signed the CLA

[brendandburns]

Thanks for the PR! The diffs here make me nervous that we're introducing a regression (and I'm not 100% how perfect our coverage is here...)

Any chance you can refactor the PR to minimize diffs?

It looks like you included some cleanups along with new code. Any chance you can break them into two commits (or two PRs) so that I can review the cleanup and the new code separately?

Thanks!
(and sorry for the delay in reviewing...)

[DavidParks8]

When implementing this, I faced the issue of either deduplicating, or copying the new constructors for each isolated platform. I chose to deduplicate (either way, the changeset would be large unless this PR didn't include parity across platforms). Since the major deduplication happened for the mono platform, I went ahead and dereferenced the new code into what the existing constructor would look like if the functions were inlined, then did a diff with the constructor from before this change. This resulted in the following changes: https://www.diffchecker.com/h24E7Ct7

Is that sufficient to show the relative risk?

[brendandburns]

Looks to me like this code was dropped? (I could be wrong...)

[brendandburns]

Oh, is it in the constructor above? I would just move all of that down here....

[DavidParks8]

I would, but doing so won't compile because CaCerts only has an empty getter that needs to be assigned where it is declared, or directly within a constructor.

[brendandburns]

Ok, I'm more comfortable with this now, one note about moving where CaCerts and IsTLSVerify is initialized and I think we're good to merge.

Thanks for the patience.

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, DavidParks8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[DavidParks8]

Thanks!