-
Notifications
You must be signed in to change notification settings - Fork 305
watcher to support empty response #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watcher to support empty response #313
Conversation
examples/watch/Program.cs
Outdated
@@ -13,8 +13,8 @@ private static void Main(string[] args) | |||
|
|||
IKubernetes client = new Kubernetes(config); | |||
|
|||
var podlistResp = client.ListNamespacedPodWithHttpMessagesAsync("default", watch: true).Result; | |||
using (podlistResp.Watch<V1Pod>((type, item) => | |||
var podlistResp = client.ListNamespacedPodWithHttpMessagesAsync("tester", watch: true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this as "default" I changed it for my cluster, but I should have reverted it...
LGTM, but CI is failing and there's one small change. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
my proposal for #308
move the async support into watcher to keep the
semantic meaning
of watchertested on empty ns