Use Path.DirectorySeparatorChar to have ServiceAccountPath start from root

[darobs]

The path constructed in KubernetesClientConfiguration::ServiceAccountPath is a relative path, and this works fine as long as CWD is the root directory.

This PR uses Path.DirectorySeparatorChar to have ServiceAccountPath start from root, instead of a relative path.

This should work fine on Linux containers, but it still assumes the Windows container working drive is "C:"

[k8s-ci-robot]

Welcome @darobs!

It looks like this is your first PR to kubernetes-client/csharp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/csharp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[tg123]

do you mean c:/var/xxxx ?

[darobs]

do you mean c:/var/xxxx ?

In Windows, this pathname resolves to \var\run\secrets\kubernetes.io\serviceaccount, which will resolve to the root of the current working drive.

Example:

PS C:\temp> type a.txt
Hello world!
PS C:\temp> type \temp\a.txt
Hello world!
PS C:\temp> d:
PS D:\Windows> type \temp\a.txt
type : Cannot find path 'D:\temp\a.txt' because it does not exist.

So this PR works fine if the current working directory in the Windows container is on the same drive as \var\run\secrets\kubernetes.io is mounted. It fixes the problem for Linux.

[tg123]

@darobs
is there any thing in C:\var\run\secrets\kubernetes.io\serviceaccount?
those are inject by system, I am not sure if it still there on Windows

IHMO, we need to find out a Windows way to do so.

[brendandburns]

/lgtm
/approve

Regardless of windows or not this is an improvement on the current code.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, darobs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment