[breaking changes] cleanup targets #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to cleanup targets to ensure the quality of code
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
remove xamarin ios and android as they can reference netstandard2 directly (confirmed here #140)
removing those targets would also help building issues (#357)
and this is the first step to build nuget on gh action (cannot target xaramin). #239 #317
here is the matrix after this patch
some comments for why other platforms are kept/removed:
net452it is still supported by MS until 2023netstandard1.4sincenetcore1.0is no longer support, netcore app should migrate to netcore2, we drop support fornetstandard1therenetcoreapp2.1, I am working on to migrated those certificates code to purenetstandard2.0will send another PR after this is mergednet461, included innetstandard2.0see aslo
#303 #345