-
Notifications
You must be signed in to change notification settings - Fork 305
Ensure that awaits do not continue on the captured context. #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that awaits do not continue on the captured context. #370
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @andykernahan! |
/check-cla |
eeae092
to
0f9e00c
Compare
/LGTM IHMO |
rebase master to pass the ci |
0f9e00c
to
3aba8ba
Compare
/LGTM |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andykernahan, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi,
This PR is a continuation of #353 which addressed #352 . Unfortunately, the synchronous methods still result in deadlock when invoked from a non-default synchronization context; this is caused by an await in the call graph continuing on the captured context.
For example, the following call graph results in deadlock:
I have also taken the opportunity to update all other awaits in non-generated code.
Cheers.