Skip to content

fix for NO_EXECUTE toString Method #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix for NO_EXECUTE toString Method #2343

merged 1 commit into from
Aug 18, 2022

Conversation

priyal13m
Copy link
Contributor

@priyal13m priyal13m commented Aug 16, 2022 •
edited
Loading

  • fixed spelling mistake in NO_EXECUTE toString Method.
  • added unit tests for NO_EXECUTE toString Method

Fixes #2340

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @priyal13m!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2022
@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for the PR!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 16, 2022
@priyal13m
Squashed commit to fix NO_EXECUTE toString method
af8621d 
commit 1625b3e
Author: Priyal P. Mujumdar <[email protected]>
Date:   Tue Aug 16 13:28:43 2022 +0530

    added unit test for NO_EXECUTE toString method

commit 1c8bcb1
Author: Priyal P. Mujumdar <[email protected]>
Date:   Tue Aug 16 13:27:32 2022 +0530

    fixed toString method for NO_EXECUTE

fixed source format
@brendandburns
Copy link
Contributor

/approve

@brendandburns
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, priyal13m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@priyal13m
Copy link
Contributor Author

@brendandburns - This is my first PR and need some guidance here. Java 11.0.x Maven Test on windows-latest failed for -

Error: testSimpleRateLimitQueue(io.kubernetes.client.extended.workqueue.DefaultRateLimitQueueTest) Time elapsed: 0.518 s <<< FAILURE!

@k8s-ci-robot
Copy link
Contributor

@priyal13m: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 64f790b into kubernetes-client:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Taints.Effect.NO_EXECUTE.toString() returns "NoExcute" instead of "NoExecute"
3 participants
@priyal13m @k8s-ci-robot @brendandburns