Delete label

[shubhbapna]

Resolves #2422

• added deleteLabel method in the KubectlLabel class

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: shubhbapna / name: Shubh Bapna (189cff7, e1065ee)

[k8s-ci-robot]

Welcome @shubhbapna!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thanks for the PR.

I don't actually think that the tests in this test (either the tests that you added, or the tests that were in the file) actually test anything other than the fact that network calls are being made.

Specifically it seems like we should be checking that the body of the PUT request looks correct (in all cases) and we don't do that.

If you wanted to fix these tests, that would be awesome, but I don't necessarily want to gate this PR on fixing tests that were not something you added, so I'm ok to merge this PR and then file an issue to get these tests fixed in a different PR.

Let me know what you think.

[brendandburns]

cc @yue9944882

[brendandburns]

I went ahead and fixed the existing tests in #2471

@shubhbapna can you add similar tests to this PR?

[shubhbapna]

Yep will do!

[shubhbapna]

Should I wait for #2471 to be merged, pull those changes and then fix the tests? Or should I fix them right now and resolve any merge conflicts later?

[yue9944882]

@shubhbapna overall LGTM, and #2471 has been merged, can you rebase onto the latest?

[yue9944882]

@shubhbapna can you run the formatter by mvn spotless:apply so that the test can pass?

[shubhbapna]

@yue9944882 @brendandburns Rebased, fixed the tests and ran the formatter

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, shubhbapna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment