Skip to content

update kubernetes links & others #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

update kubernetes links & others #2473

merged 1 commit into from
Dec 1, 2022

Conversation

Arhell
Copy link
Contributor

@Arhell Arhell commented Nov 28, 2022

resolve #2470

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2022
@brendandburns
Copy link
Contributor

This is fine, but rather than a bunch of small PRs can we do a single big PR that fixes this for all links in any markdown file?

@Arhell Arhell marked this pull request as ready for review November 29, 2022 22:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@Arhell
Copy link
Contributor Author

Arhell commented Nov 29, 2022

This is fine, but rather than a bunch of small PRs can we do a single big PR that fixes this for all links in any markdown file?

Possibly, but in the next PR

@brendandburns
Copy link
Contributor

I'd prefer if you just added commits to this PR, that way it's clearer in the history. In general there's a preference for fewer PRs vs. lots of PRs.

You can add commits to your local git repo and then use git push .. to push them into this PR's branch.

Thanks!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2022
@Arhell Arhell changed the title update root folder links update kubernetes links & others Nov 30, 2022
@Arhell
Copy link
Contributor Author

Arhell commented Nov 30, 2022

@brendandburns done

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arhell, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 546f290 into kubernetes-client:master Dec 1, 2022
@Arhell Arhell deleted the upd-root branch December 1, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update root folder links
3 participants
@Arhell @brendandburns @k8s-ci-robot