Refactor utils

[abhiabhi94]

• move regex compilation to the top of the module to enable caching.

closes #1381

[k8s-ci-robot]

Welcome @abhiabhi94!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[yliaog]

thanks for the pr

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhiabhi94, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhiabhi94]

Hey @yliaog, inside the script update-pycodestyle, we try to reorder the imports using isort by using isort -y

python/scripts/update-pycodestyle.sh

Lines 69 to 71 in 6d64cf6

	for SOURCE in $SOURCES; do
	isort -y $SOURCE
	done

The argument -y has been deprecate for isort versions >=5 and is applied by default.

For older versions:

$ pip freeze -l | grep -i isort
isort==4.3.21

$ isort --help | grep -Ee '\-y'
             [-w LINE_LENGTH] [-wl WRAP_LENGTH] [-ws] [-y] [--unsafe]
  -y, --apply           Tells isort to apply changes recursively without

Newer version:

$ pip freeze -l | grep -i isort
isort==5.7.0
$ isort --help | grep -Ee '\-y' 
$

I think this has not been caught because as far as I can see, the environment the tox environment update-pycodestyle is not being run in travis. Is this expected behavior?

Also, if we want to a consistent style as mentioned in the contributing notes, maybe we can automate this by using a pre-commit hook that runs this particular script?

[yliaog]

closing to trigger CI
/close

[k8s-ci-robot]

@yliaog: Closed this PR.

In response to this:

closing to trigger CI
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yliaog]

/reopen

[k8s-ci-robot]

@yliaog: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yliaog]

update-pycodestyle is used here (https://github.com/kubernetes-client/python/blob/master/.travis.yml#L28), i agree it should be applied consistently for other versions.

[abhiabhi94]

Regarding the pycodestyle, if you agree to maybe should I setup a pre-commit hook that would run this script before the commit to help automate this process(for the developer), or provide feedback before the commit(in case there are inconsistencies)?