Skip to content

Re-generate client for 9.0.0 release #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2019

Conversation

roycaihw
Copy link
Member

mostly version constant update. One bug fix in custom objects API to add an optional parameter

will update the CHANGELOG and README in master branch later

/assign @yliaog

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from mbohlool and yliaog March 19, 2019 01:44
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 19, 2019
@micw523
Copy link
Contributor

micw523 commented Mar 19, 2019

May want to drop support for v6.0 since we're rolling out a stable version?

@yliaog
Copy link
Contributor

yliaog commented Mar 19, 2019

i don't see the file custom_objects_spec.json for the bug fix

@roycaihw
Copy link
Member Author

May want to drop support for v6.0 since we're rolling out a stable version?

@micw523 updated

i don't see the file custom_objects_spec.json for the bug fix

@yliaog the file is in the gen repo. We use gen repo from HEAD to re-generate the client

@yliaog
Copy link
Contributor

yliaog commented Mar 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d3aff05 into kubernetes-client:release-9.0 Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants