This repository was archived by the owner on Dec 6, 2024. It is now read-only.
This repository was archived by the owner on Dec 6, 2024. It is now read-only.
[2021-04-16] - CRDs are created with api-approved annotation, but did not complete API review #38
Closed
Description
Bug Report
https://github.com/kubernetes-sigs/container-object-storage-interface-api/blob/master/kustomization.yaml#L10 adds an api-approved annotation to all loaded CRDs
The APIs in question have not actually been approved via the k8s API review process
Additionally, using a mixin to automatically add the annotation to all CRDs is not appropriate... it confers approval status on any newly introduced CRDs or updates to CRD manifests without actual review / approve.
As noted in https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2337-k8s.io-group-protection/README.md#proposal, until the API is approved, a string starting with unapproved
can be used as a placeholder
cc @thockin
Metadata
Metadata
Assignees
Labels
No labels