This repository was archived by the owner on Sep 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 292
Persist encrypted credentials under the credentials/
directory
#125
Merged
mumoshu
merged 1 commit into
kubernetes-retired:master
from
mumoshu:persist-encrypted-creds-to-fix-stack-update
Dec 7, 2016
Merged
Persist encrypted credentials under the credentials/
directory
#125
mumoshu
merged 1 commit into
kubernetes-retired:master
from
mumoshu:persist-encrypted-creds-to-fix-stack-update
Dec 7, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 68.44% (diff: 81.30%)@@ master #125 diff @@
==========================================
Files 5 5
Lines 997 1071 +74
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 663 733 +70
Misses 253 253
- Partials 81 85 +4
|
You can verify that the original issue is resolved by running
|
32c1b61
to
9f48c12
Compare
E2E and unit tests are improved to cover this. |
Rebased to the latest master and E2E tests passed. |
9f48c12
to
221e5d8
Compare
so that we can prevent unnecessary node replacement when `kube-aws update` run. Encrypted credentials are named with the suffix `.enc` hence `*-key.pem.enc` for keys, `*.pem.env` for certs, and `ca.pem.enc` for ca cert. If you've removed one of more `*.enc` files, `kube-aws (validate|up)` automatically re-generate not only removed ones but "all" the `*.enc` files by encrypting pem files. The whole file tree representing kube-aws' state after `kube-aws init` now look like: ``` $ tree e2e/assets/ e2e/assets/ └── kubeawstest2 ├── cluster.yaml ├── credentials │ ├── admin-key.pem │ ├── admin-key.pem.enc │ ├── admin.pem │ ├── admin.pem.enc │ ├── apiserver-key.pem │ ├── apiserver-key.pem.enc │ ├── apiserver.pem │ ├── apiserver.pem.enc │ ├── ca-key.pem │ ├── ca-key.pem.enc │ ├── ca.pem │ ├── ca.pem.enc │ ├── etcd-client-key.pem │ ├── etcd-client-key.pem.enc │ ├── etcd-client.pem │ ├── etcd-client.pem.enc │ ├── etcd-key.pem │ ├── etcd-key.pem.enc │ ├── etcd.pem │ ├── etcd.pem.enc │ ├── worker-key.pem │ ├── worker-key.pem.enc │ ├── worker.pem │ └── worker.pem.enc ├── kubeconfig ├── stack-template.json └── userdata ├── cloud-config-controller ├── cloud-config-etcd └── cloud-config-worker 3 directories, 30 files ``` fixes kubernetes-retired#107
221e5d8
to
194ff10
Compare
It turns out we just need one or more .enc files removed to regenerate not only remove ones but all the enc files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we can prevent unnecessary node replacement when
kube-aws update
run.Encrypted credentials are named with the suffix
.enc
hence*-key.pem.enc
for keys,*.pem.env
for certs, andca.pem.enc
for ca cert.If you've removed one of more
*.enc
files,kube-aws (validate|up)
automatically re-generate not only removed ones but "all" the*.enc
files by encrypting pem files.The whole file tree representing kube-aws' state after
kube-aws init
now look like:fixes #107
cc @pieterlange