Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Option to pretty print CloudFormation JSON #153

Merged

Conversation

cknowles
Copy link
Contributor

Means stack contents are easier to compare out of the box

Means stack contents are easier to compare out of the box
@codecov-io
Copy link

codecov-io commented Dec 12, 2016

Current coverage is 69.68% (diff: 66.66%)

Merging #153 into master will decrease coverage by 0.22%

@@             master       #153   diff @@
==========================================
  Files             5          4     -1   
  Lines          1110       1095    -15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            776        763    -13   
+ Misses          249        248     -1   
+ Partials         85         84     -1   

Powered by Codecov. Last update 56f08d5...974e003

}{}
)

func init() {
NodePoolCmd.AddCommand(cmdUpdate)
cmdUpdate.Flags().BoolVar(&updateOpts.awsDebug, "aws-debug", false, "Log debug information from aws-sdk-go library")
cmdUpdate.Flags().BoolVar(&updateOpts.prettyPrint, "prettyPrint", false, "Pretty print the resulting CloudFormation")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-knowles I like this more if it were pretty-print instead of prettyPrint for consistency with other flags like aws-debug 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mumoshu mumoshu merged commit c3a7d71 into kubernetes-retired:master Dec 14, 2016
@mumoshu
Copy link
Contributor

mumoshu commented Dec 14, 2016

@c-knowles LGTM. Thanks as always 👍

@mumoshu mumoshu added this to the v0.9.2-rc.5 milestone Dec 14, 2016
@cknowles cknowles deleted the feature/pretty-print-exports branch February 22, 2017 02:56
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
* Option to pretty print CloudFormation JSON

Means stack contents are easier to compare out of the box

* Aligned pretty print arg case to others
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants