Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

[v1.16.1] Update API version for deployment, as v1beta1 is deprecated. #1870

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

dominicgunn
Copy link
Contributor

Changes

  • apps/v1beta1 has been deprecated, we need to remove reference to it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dominicgunn
You can assign the PR to them by writing /assign @dominicgunn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #1870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   24.41%   24.41%           
=======================================
  Files          98       98           
  Lines        5116     5116           
=======================================
  Hits         1249     1249           
  Misses       3727     3727           
  Partials      140      140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43cd06...6643094. Read the comment docs.

@dominicgunn dominicgunn merged commit 2ed6d7d into master Jun 1, 2020
@dominicgunn dominicgunn added this to the v0.16.1 milestone Jul 3, 2020
@cblecker cblecker deleted the feature/v0.16.1-apiVersion-canal branch September 30, 2020 16:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants