Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Shield cfn-signal behind experimental flag. #82

Conversation

pieterlange
Copy link
Contributor

In preparation for node cordoning/uncordon process 1/2

I think it's safer to have an easy way to disable this while we work on it.

Note that this reverts the PauseTime to 2 minutes and the WorkerCreateTimeout / ControllerCreateTimeout remain top level variables.

@codecov-io
Copy link

codecov-io commented Nov 22, 2016

Current coverage is 55.19% (diff: 100%)

Merging #82 into master will increase coverage by 0.17%

@@             master        #82   diff @@
==========================================
  Files             4          4          
  Lines          1045       1049     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            575        579     +4   
  Misses          388        388          
  Partials         82         82          

Powered by Codecov. Last update ffe8d27...622a8c1

@pieterlange pieterlange force-pushed the feature/experimental-wait-signal branch 2 times, most recently from 58bf89d to 3d465a6 Compare November 22, 2016 15:14
@mumoshu
Copy link
Contributor

mumoshu commented Nov 22, 2016

If you have not yet done so, make format seems to be required!

In preparation for node cordoning/uncordon process 1/2
@pieterlange pieterlange force-pushed the feature/experimental-wait-signal branch from 3d465a6 to 622a8c1 Compare November 22, 2016 15:23
@pieterlange
Copy link
Contributor Author

Will i ever learn..

@mumoshu mumoshu mentioned this pull request Nov 22, 2016
8 tasks
@pieterlange
Copy link
Contributor Author

Real world check successful. LGTM 👍

@mumoshu mumoshu merged commit 48e295f into kubernetes-retired:master Nov 23, 2016
@mumoshu
Copy link
Contributor

mumoshu commented Nov 23, 2016

Thanks as always, @pieterlange!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants