-
Notifications
You must be signed in to change notification settings - Fork 293
Option to automatically assign externally managed ELBs to the worker autoscaling group #93
Option to automatically assign externally managed ELBs to the worker autoscaling group #93
Conversation
Current coverage is 55.66% (diff: 100%)@@ master #93 diff @@
==========================================
Files 4 4
Lines 1057 1060 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 587 590 +3
Misses 388 388
Partials 82 82
|
@pieterlange I believe this is what everyone(of course including me 😄) can benefit from when one wants to use ELB(s) to proxy or loadbalance requests to specific nodePorts, which might be a very common use-case 👍 IMHO, it is also a fairly common use-case that multiple services to be load-balanced are hosted on a single group of nodes hence it needs to be attached to multiple ELBs. |
ac07dfd
to
59bc736
Compare
No problem..! Comin' up. |
c933d6b
to
f68ea8b
Compare
May i ask why you wouldn't simply use the This is really only for the 'odd' setups where you need to manually/externally configure the ELB with some settings that can't be configured from kubernetes itself. |
Also be aware that updating the loadbalancer names replaces the entire autoscaling group. |
To use this feature correctly the operator must currently create a manual "glue" securitygroup with inbound rules allowing for every ELB port routed to a It might be more intuitive to actually reference the ELB securitygroup and simply add a new |
@pieterlange Thanks for your effort! My use-case is #93 (comment) plus a downtime-less kubernetes cluster replacement with less scripting/manual work. I've never considered using I'd like ELBs to survive between multiple recreations of associated kubernetes clusters so that there's no need of manual work/additional scripting like:
instead we can now do:
I even assume this is not very odd but occasionally needed setup 😄 |
@pieterlange Would you mind rebasing this? |
f68ea8b
to
8690b52
Compare
Rebased and alphabetically sorted the |
autoscaling group
8690b52
to
b4b1eba
Compare
Thanks for rebasing and the good idea 👍 |
This is useful for operators that have special ELB requirements like the proxyprotocol or where loadbalancer/network asset management is delegated to a different team.