Skip to content

[release-1.17] bug: Fix APIServerLB nil pointer deref #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[release-1.17] bug: Fix APIServerLB nil pointer deref #5456

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5453

/assign nawazkh

Fixes a possible nil pointer deference when returning the name of the API Server LoadBalancer. In some cases like externally managed infrastructure, there might not be an API Server LoadBalancer in the AzureCluster CR

@bryan-cox
bug: Fix APIServerLB nil pointer deref
deff63f 
This commit fixes a possible nil pointer deference when returning the
name of the API Server LoadBalancer. In some cases like externally
managed infrastructure, there might not be an API Server LoadBalancer in
 the AzureCluster CR.

Signed-off-by: Bryan Cox <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 26, 2025
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2025
@nawazkh
Copy link
Member

nawazkh commented Feb 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 513cd063c829ec07468e55ebc349d27e74f27e6c

@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test-v1beta1 deff63f link true /test pull-cluster-api-provider-azure-test-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nawazkh
Copy link
Member

nawazkh commented Feb 27, 2025 •
edited
Loading 

azure/scope/cluster_test.go:4272:21: cannot use &infrav1.LoadBalancerSpec{…} (value of type *"sigs.k8s.io/cluster-api-provider-azure/api/v1beta1".LoadBalancerSpec) as "sigs.k8s.io/cluster-api-provider-azure/api/v1beta1".LoadBalancerSpec value in struct literal (typecheck)

This PR will need some manual tweaking.

@nawazkh
Copy link
Member

nawazkh commented Feb 27, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@nawazkh nawazkh mentioned this pull request Feb 27, 2025
Merged
@nawazkh
Copy link
Member

nawazkh commented Feb 27, 2025

Opened up a manual cherry-pick #5458
/close

@k8s-ci-robot
Copy link
Contributor

@nawazkh: Closed this PR.

In response to this:

Opened up a manual cherry-pick #5458
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Awaiting requested review from Jont828

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@nawazkh nawazkh

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @nawazkh @bryan-cox