Skip to content

[release-1.18] Tiltfile aks as mgmt improvements #5463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5451

/assign nawazkh

Update Tiltfile and add documentation on using AKS as mgmt cluster

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 3, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 3, 2025

Will approve post tests.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcf4bd183942d016e2af062f41519555e197122a

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.42%. Comparing base (929741a) to head (1c28e12).
Report is 7 commits behind head on release-1.18.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.18    #5463   +/-   ##
=============================================
  Coverage         52.42%   52.42%           
=============================================
  Files               272      272           
  Lines             29365    29365           
=============================================
  Hits              15394    15394           
  Misses            13165    13165           
  Partials            806      806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh nawazkh moved this from Todo to In Progress in CAPZ Planning Mar 3, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 3, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4a23122 into kubernetes-sigs:release-1.18 Mar 3, 2025
21 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in CAPZ Planning Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants