-
Notifications
You must be signed in to change notification settings - Fork 448
fix linter errors #5466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linter errors #5466
Conversation
I wonder why the verify job did not catch this in #5452 ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5466 +/- ##
=======================================
Coverage 52.55% 52.56%
=======================================
Files 272 272
Lines 29423 29423
=======================================
+ Hits 15463 15465 +2
+ Misses 13153 13151 -2
Partials 807 807 ☔ View full report in Codecov by Sentry. |
Looks like the setting "Approval for running fork pull request workflows from contributors" was set to "needs approval for all external contributors". I changed it to "need approval for first timers contributing to this repo" so that we don't miss out on running the GitHub Actions from external contributors who have already committed to this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: c5e1a4866b5f067bba6eba5b48e60c599f9b63bc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Gist: #5466 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: