Skip to content

fix linter errors #5466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Mar 4, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Gist: #5466 (comment)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and marosset March 4, 2025 18:23
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Mar 4, 2025

I wonder why the verify job did not catch this in #5452 ?

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.56%. Comparing base (057907a) to head (7fdbf76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5466   +/-   ##
=======================================
  Coverage   52.55%   52.56%           
=======================================
  Files         272      272           
  Lines       29423    29423           
=======================================
+ Hits        15463    15465    +2     
+ Misses      13153    13151    -2     
  Partials      807      807           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh
Copy link
Member Author

nawazkh commented Mar 4, 2025

I wonder why the verify job did not catch this in #5452 ?

Looks like none of the GitHub Actions ran on #5452. Strange. Is it because the PR was from a non-maintainer ? Probing..

@nawazkh
Copy link
Member Author

nawazkh commented Mar 4, 2025

I wonder why the verify job did not catch this in #5452 ?

Looks like none of the GitHub Actions ran on #5452. Strange. Is it because the PR was from a non-maintainer ? Probing..

Looks like the setting "Approval for running fork pull request workflows from contributors" was set to "needs approval for all external contributors". I changed it to "need approval for first timers contributing to this repo" so that we don't miss out on running the GitHub Actions from external contributors who have already committed to this repository.

Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5e1a4866b5f067bba6eba5b48e60c599f9b63bc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot merged commit ab2bbfb into kubernetes-sigs:main Mar 4, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 4, 2025
@nawazkh nawazkh deleted the fix_linter_errors branch March 4, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants