Skip to content

[release-1.19] Ensure all agent pool parameters are preserved in managed cluster creates #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5521

/assign nojnhuh

Fixed a bug causing an unnecessary update to an AKS agent pool after its managed cluster is created when certain fields are defined.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 28, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.61%. Comparing base (0172e1f) to head (1c994c5).
Report is 3 commits behind head on release-1.19.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.19    #5524      +/-   ##
================================================
+ Coverage         52.57%   52.61%   +0.03%     
================================================
  Files               272      272              
  Lines             29470    29485      +15     
================================================
+ Hits              15495    15513      +18     
+ Misses            13167    13165       -2     
+ Partials            808      807       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor

nojnhuh commented Mar 28, 2025

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2d8de4ce620b7fc7ed9b9cb4dee57c67faa0d65

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 42126a4 into kubernetes-sigs:release-1.19 Mar 28, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants