Skip to content

[release-1.18] fix: support ClusterCacheTracker #5572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5556

/assign nawazkh

fixes manager deployment to enable cluster cache tracker

POD_UID is required for clusterCacheTracker to work
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.35%. Comparing base (d181051) to head (2ac219c).
Report is 9 commits behind head on release-1.18.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.18    #5572   +/-   ##
=============================================
  Coverage         52.34%   52.35%           
=============================================
  Files               272      272           
  Lines             29356    29356           
=============================================
+ Hits              15367    15369    +2     
+ Misses            13188    13186    -2     
  Partials            801      801           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

/retest

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

/retest

3 similar comments
@mboersma
Copy link
Contributor

/retest

@nawazkh
Copy link
Member

nawazkh commented Apr 28, 2025

/retest

@mboersma
Copy link
Contributor

/retest

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8c07ec56b013a15014ee67085c2c36e6d4656d19

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@mboersma
Copy link
Contributor

/retest

2 similar comments
@mboersma
Copy link
Contributor

/retest

@mboersma
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 34359e2 into kubernetes-sigs:release-1.18 Apr 29, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-v1beta1 2ac219c link unknown /test pull-cluster-api-provider-azure-e2e-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants