-
Notifications
You must be signed in to change notification settings - Fork 448
[release-1.19] fix: support ClusterCacheTracker #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.19] fix: support ClusterCacheTracker #5573
Conversation
POD_UID is required for clusterCacheTracker to work
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.19 #5573 +/- ##
=============================================
Coverage 52.54% 52.54%
=============================================
Files 272 272
Lines 29474 29474
=============================================
+ Hits 15486 15488 +2
+ Misses 13186 13184 -2
Partials 802 802 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/retest |
/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 |
Rather strange that this PR is failing consistently on |
/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 |
/retest |
[FAILED] Provided Kubernetes version v1.30.11 does not have a corresponding VM image in the "capi offer"
Expected
<semver.Versions | len:15, cap:17>: [
{Major: 1, Minor: 30, Patch: 7, Pre: nil, Build: nil},
{Major: 1, Minor: 31, Patch: 1, Pre: nil, Build: nil},
{Major: 1, Minor: 31, Patch: 4, Pre: nil, Build: nil},
{Major: 1, Minor: 29, Patch: 10, Pre: nil, Build: nil},
{Major: 1, Minor: 29, Patch: 11, Pre: nil, Build: nil},
{Major: 1, Minor: 32, Patch: 0, Pre: nil, Build: nil},
{Major: 1, Minor: 31, Patch: 3, Pre: nil, Build: nil},
{Major: 1, Minor: 28, Patch: 15, Pre: nil, Build: nil},
{Major: 1, Minor: 29, Patch: 12, Pre: nil, Build: nil},
{Major: 1, Minor: 30, Patch: 8, Pre: nil, Build: nil},
{Major: 1, Minor: 30, Patch: 5, Pre: nil, Build: nil},
{Major: 1, Minor: 27, Patch: 16, Pre: nil, Build: nil},
{Major: 1, Minor: 30, Patch: 6, Pre: nil, Build: nil},
{Major: 1, Minor: 31, Patch: 2, Pre: nil, Build: nil},
{Major: 1, Minor: 28, Patch: 10, Pre: nil, Build: nil},
]
to contain element matching
<semver.Version>: {Major: 1, Minor: 30, Patch: 11, Pre: nil, Build: nil}
In [SynchronizedBeforeSuite] at: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/e2e/helpers.go:815 @ 04/26/25 19:24:21.553 It appears in this branch on the upgrade test we're still running code that gets images from the Marketplace...I think. At least I'm not sure why this error appears otherwise, and the code in the traceback doesn't seem to match @nawazkh maybe we went too far for now by saying k8s v1.30.11 is the minimum? According to the list above we could get away with v1.30.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
LGTM label has been added. Git tree hash: 98d8c0c67cfebf13c2f52d497f32d2b5999c864f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
This is an automated cherry-pick of #5556
/assign nawazkh