Skip to content

[release-1.19] fix: support ClusterCacheTracker #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #5556

/assign nawazkh

fixes manager deployment to enable cluster cache tracker

POD_UID is required for clusterCacheTracker to work
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 18, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and nojnhuh April 18, 2025 15:36
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (1d0349e) to head (5f9b9b2).
Report is 6 commits behind head on release-1.19.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.19    #5573   +/-   ##
=============================================
  Coverage         52.54%   52.54%           
=============================================
  Files               272      272           
  Lines             29474    29474           
=============================================
+ Hits              15486    15488    +2     
+ Misses            13186    13184    -2     
  Partials            802      802           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

/retest

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

@nawazkh
Copy link
Member

nawazkh commented Apr 18, 2025

Rather strange that this PR is failing consistently on pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
On the surface it looks like a timeout issue. flake. Could it be more?
Will probe again if this run fails.
/retest

@nawazkh
Copy link
Member

nawazkh commented Apr 23, 2025

/test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1

@mboersma
Copy link
Contributor

/retest

@mboersma
Copy link
Contributor

  [FAILED] Provided Kubernetes version v1.30.11 does not have a corresponding VM image in the "capi offer"
  Expected
      <semver.Versions | len:15, cap:17>: [
          {Major: 1, Minor: 30, Patch: 7, Pre: nil, Build: nil},
          {Major: 1, Minor: 31, Patch: 1, Pre: nil, Build: nil},
          {Major: 1, Minor: 31, Patch: 4, Pre: nil, Build: nil},
          {Major: 1, Minor: 29, Patch: 10, Pre: nil, Build: nil},
          {Major: 1, Minor: 29, Patch: 11, Pre: nil, Build: nil},
          {Major: 1, Minor: 32, Patch: 0, Pre: nil, Build: nil},
          {Major: 1, Minor: 31, Patch: 3, Pre: nil, Build: nil},
          {Major: 1, Minor: 28, Patch: 15, Pre: nil, Build: nil},
          {Major: 1, Minor: 29, Patch: 12, Pre: nil, Build: nil},
          {Major: 1, Minor: 30, Patch: 8, Pre: nil, Build: nil},
          {Major: 1, Minor: 30, Patch: 5, Pre: nil, Build: nil},
          {Major: 1, Minor: 27, Patch: 16, Pre: nil, Build: nil},
          {Major: 1, Minor: 30, Patch: 6, Pre: nil, Build: nil},
          {Major: 1, Minor: 31, Patch: 2, Pre: nil, Build: nil},
          {Major: 1, Minor: 28, Patch: 10, Pre: nil, Build: nil},
      ]
  to contain element matching
      <semver.Version>: {Major: 1, Minor: 30, Patch: 11, Pre: nil, Build: nil}
  In [SynchronizedBeforeSuite] at: /home/prow/go/src/sigs.k8s.io/cluster-api-provider-azure/test/e2e/helpers.go:815 @ 04/26/25 19:24:21.553

It appears in this branch on the upgrade test we're still running code that gets images from the Marketplace...I think. At least I'm not sure why this error appears otherwise, and the code in the traceback doesn't seem to match main.

@nawazkh maybe we went too far for now by saying k8s v1.30.11 is the minimum? According to the list above we could get away with v1.30.8.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 98d8c0c67cfebf13c2f52d497f32d2b5999c864f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@mboersma
Copy link
Contributor

/retest

2 similar comments
@mboersma
Copy link
Contributor

/retest

@mboersma
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit aaeba8c into kubernetes-sigs:release-1.19 Apr 29, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants