-
Notifications
You must be signed in to change notification settings - Fork 446
Enable new AKS API version with ASO API #5622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new AKS API version with ASO API #5622
Conversation
Hi @alimaazamat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
LGTM label has been added. Git tree hash: 3730dd1eb13f23b89cdaebd6183fd64471609df0
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5622 +/- ##
==========================================
- Coverage 53.28% 53.27% -0.01%
==========================================
Files 272 272
Lines 29521 29522 +1
==========================================
- Hits 15729 15727 -2
- Misses 12977 12980 +3
Partials 815 815 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/ok-to-test |
It might also be a good time to bump the version we test with to this latest version. A cursory look suggests a repo-wide search/replace for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's probably mentioning in the release note that the aks-aso
and aks-aso-clusterclass
flavor templates now use the new API version.
/lgtm
/approve
/hold for the release note
^ Feel free to drop the hold once the release note is added.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 382189bde5524df3e23e214c47d511d2046aa85d
|
/hold cancel |
/cherry-pick release-1.19 |
@nawazkh: new pull request created: #5626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Enables the new AKS API version with the ASO API (AzureAKSManagedControlPlane etc).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5520
Special notes for your reviewer:
TODOs:
Release note: