Skip to content

Enable new AKS API version with ASO API #5622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alimaazamat
Copy link
Contributor

@alimaazamat alimaazamat commented May 8, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Enables the new AKS API version with the ASO API (AzureAKSManagedControlPlane etc).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5520

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Upgraded aks-aso and aks-aso-clusterclass flavor templates to use the new API version.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @alimaazamat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2025
@alimaazamat alimaazamat changed the title enable new AKS API version with ASO API Enable new AKS API version with ASO API May 8, 2025
@nawazkh
Copy link
Member

nawazkh commented May 8, 2025

/lgtm
/cc @nojnhuh

@k8s-ci-robot k8s-ci-robot requested a review from nojnhuh May 8, 2025 16:46
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3730dd1eb13f23b89cdaebd6183fd64471609df0

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (66244df) to head (d87c66b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5622      +/-   ##
==========================================
- Coverage   53.28%   53.27%   -0.01%     
==========================================
  Files         272      272              
  Lines       29521    29522       +1     
==========================================
- Hits        15729    15727       -2     
- Misses      12977    12980       +3     
  Partials      815      815              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mboersma
Copy link
Contributor

mboersma commented May 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 8, 2025
@nawazkh nawazkh moved this from Todo to Needs Review in CAPZ Planning May 8, 2025
@nawazkh nawazkh added this to the v1.20 milestone May 8, 2025
@nojnhuh
Copy link
Contributor

nojnhuh commented May 8, 2025

It might also be a good time to bump the version we test with to this latest version. A cursory look suggests a repo-wide search/replace for containerservice.azure.com/v1api20231001 with the new version might be enough.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from nawazkh May 8, 2025 22:45
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2025
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably mentioning in the release note that the aks-aso and aks-aso-clusterclass flavor templates now use the new API version.

/lgtm
/approve
/hold for the release note

^ Feel free to drop the hold once the release note is added.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 382189bde5524df3e23e214c47d511d2046aa85d

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 9, 2025
@alimaazamat
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3a9eb5b into kubernetes-sigs:main May 9, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in CAPZ Planning May 9, 2025
@nawazkh
Copy link
Member

nawazkh commented May 9, 2025

/cherry-pick release-1.19

@k8s-infra-cherrypick-robot

@nawazkh: new pull request created: #5626

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CAPZ fails to apply new API version of ASO resources
6 participants