🌱 Export envtest.ReadCRDFiles #3129
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| // readCRDFiles reads the directories of CRDs in options.Paths and adds the CRD structs to options.CRDs. | ||
| func readCRDFiles(options *CRDInstallOptions) error { | ||
| // ReadCRDFiles reads the directories of CRDs in options.Paths and adds the CRD structs to options.CRDs. | ||
| func ReadCRDFiles(options *CRDInstallOptions) error { |
There was a problem hiding this comment.
Not sure if I should change the input paramter to only take / return exactly what is needed.
The current input parameter is a bit awkward. On the other side we have the same in WaitForCRDs
There was a problem hiding this comment.
No strong opinion either way
|
/assign @vincepri @alvaroaleman |
| // readCRDFiles reads the directories of CRDs in options.Paths and adds the CRD structs to options.CRDs. | ||
| func readCRDFiles(options *CRDInstallOptions) error { | ||
| // ReadCRDFiles reads the directories of CRDs in options.Paths and adds the CRD structs to options.CRDs. | ||
| func ReadCRDFiles(options *CRDInstallOptions) error { |
There was a problem hiding this comment.
No strong opinion either way
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: c1d2ae023c1542c6f661e94b55d030d8302e45c9
|
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.20 |
|
@sbueringer: new pull request created: #3131 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
I would like to export ReadCRDFiles so I can use the functionality without being forced to use the entire InstallCRDs func.
CreateCRDs and WaitForCRDs are already exported