feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

SinaChavoshi · 2025-05-15T17:54:46Z

This PR introduces a new conformance test, HTTPRouteMultipleGatewaysDifferentPools, which validates a scenario where two distinct HTTPRoute resources, parented by different Gateway resources, successfully reference and route traffic to separate InferencePool backends.

local run results: ( Ran on commit fe540a7)

go test -v ./conformance -args -debug     -gateway-class gke-l7-regional-external-managed     -cleanup-base-resources=false     -run-test HTTPRouteMultipleGatewaysDifferentPools
=== RUN   TestConformance
    conformance.go:197: Registering API types with scheme...
...
--- PASS: TestConformance (42.70s)
    --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (39.18s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/HTTPRoute_for_Gateway_1_should_be_Accepted_and_Reconciled (21.20s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/InferencePool_A_(pool-a)_should_be_Accepted (0.08s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/HTTPRoute_for_Gateway_2_should_be_Accepted_and_Reconciled (15.12s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/InferencePool_B_(pool-b)_should_be_Accepted (0.06s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
PASS
ok

netlify · 2025-05-15T17:54:52Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`68812d7`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/682cf303935d3e0009fe4ecb
😎 Deploy Preview	https://deploy-preview-838--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-05-15T17:54:56Z

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

spencerhance · 2025-05-16T18:16:20Z

/cc

spencerhance

/lgtm

conformance/conformance.go

spencerhance · 2025-05-19T18:22:08Z

/lgtm

ahg-g · 2025-05-20T15:14:53Z

/ok-to-test

k8s-ci-robot · 2025-05-20T21:24:20Z

New changes are detected. LGTM label has been removed.

robscott

Thanks @SinaChavoshi! A couple tiny nits, otherwise LGTM.

robscott · 2025-05-20T23:58:38Z

conformance/resources/manifests/manifests.yaml

+        from: All
+      kinds:
+      - group: gateway.networking.k8s.io
+        kind: HTTPRoute


Don't forget trailing new lines in these files

robscott · 2025-05-21T00:01:35Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml

+    matches:
+    - path:
+        type: PathPrefix
+        value: /test-gw2


Same comment here

k8s-ci-robot · 2025-05-21T00:01:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: robscott, SinaChavoshi, spencerhance
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

robscott

Sorry, just adding a couple tiny nits as I've been thinking more broadly about how this will fit in with the rest of the conformance tests.

robscott · 2025-05-21T00:15:53Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.go

+			t.Logf("HTTPRoute %s has all references resolved by Gateway %s", routeForGW2NN.String(), gateway2NN.String())
+		})
+
+		t.Run("InferencePool B (pool-b) should be Accepted", func(t *testing.T) {


On further thought, I'd expect these tests to go further. To really ensure that this is working as expected, we should try to send a request and ensure it gets routed to the appropriate InferencePool.

robscott · 2025-05-21T00:17:13Z

conformance/tests/basic/httproute_multiple_gateways_different_pools.go

+
+		var timeoutConfig config.InferenceExtensionTimeoutConfig = config.DefaultInferenceExtensionTimeoutConfig()
+
+		t.Run("HTTPRoute for Gateway 1 should be Accepted and have ResolvedRefs", func(t *testing.T) {


It feels like a lot of what's in this test is going to get repeated in almost every conformance test. I'd recommend having some helpers that turn the wait for an HTTPRoute and InferencePool to be accepted into single line function calls for each resource.

SinaChavoshi added 2 commits May 14, 2025 22:50

copy from existing test to start with

c859896

update test and add gateway to main manifest

fe540a7

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2025

k8s-ci-robot requested review from nirrozenbaum and robscott May 15, 2025 17:54

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025

k8s-ci-robot requested a review from spencerhance May 16, 2025 18:16

spencerhance approved these changes May 16, 2025

View reviewed changes

conformance/conformance.go Show resolved Hide resolved

k8s-ci-robot assigned spencerhance May 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025

fix spelling error

63fedab

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025

check RouteConditionResolvedRefs instead of Reconciled

68812d7

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2025

robscott approved these changes May 21, 2025

View reviewed changes

robscott reviewed May 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Uh oh!

SinaChavoshi commented May 15, 2025

Uh oh!

netlify bot commented May 15, 2025 •

edited

Loading

Uh oh!

k8s-ci-robot commented May 15, 2025

Uh oh!

spencerhance commented May 16, 2025

Uh oh!

spencerhance left a comment

Uh oh!

Uh oh!

spencerhance commented May 19, 2025

Uh oh!

ahg-g commented May 20, 2025

Uh oh!

k8s-ci-robot commented May 20, 2025

Uh oh!

robscott left a comment

Uh oh!

robscott May 20, 2025

Uh oh!

robscott May 21, 2025

Uh oh!

k8s-ci-robot commented May 21, 2025

Uh oh!

robscott left a comment

Uh oh!

robscott May 21, 2025

Uh oh!

robscott May 21, 2025

Uh oh!

Uh oh!


		var timeoutConfig config.InferenceExtensionTimeoutConfig = config.DefaultInferenceExtensionTimeoutConfig()

		t.Run("HTTPRoute for Gateway 1 should be Accepted and have ResolvedRefs", func(t *testing.T) {

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Are you sure you want to change the base?

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Uh oh!

Conversation

SinaChavoshi commented May 15, 2025

Uh oh!

netlify bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented May 15, 2025

Uh oh!

spencerhance commented May 16, 2025

Uh oh!

spencerhance left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spencerhance commented May 19, 2025

Uh oh!

ahg-g commented May 20, 2025

Uh oh!

k8s-ci-robot commented May 20, 2025

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

robscott May 20, 2025

Choose a reason for hiding this comment

Uh oh!

robscott May 21, 2025

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented May 21, 2025

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

robscott May 21, 2025

Choose a reason for hiding this comment

Uh oh!

robscott May 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

netlify bot commented May 15, 2025 •

edited

Loading