feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

SinaChavoshi · 2025-05-15T17:54:46Z

This PR introduces a new conformance test, HTTPRouteMultipleGatewaysDifferentPools, which validates a scenario where two distinct HTTPRoute resources, parented by different Gateway resources, successfully reference and route traffic to separate InferencePool backends.

local run results: ( Ran on commit 0b94f9f)

go test -v ./conformance -args -debug     -gateway-class gke-l7-regional-external-managed     -cleanup-base-resources=false     -run-test HTTPRouteMultipleGatewaysDifferentPools
...
=== NAME  TestConformance
    suite.go:451: 2025-06-23T19:17:41.876673193Z: Sleeping 0s for test isolation
=== RUN   TestConformance/InferencePoolResolvedRefsCondition
    conformance.go:68: Skipping InferencePoolResolvedRefsCondition: test explicitly skipped
--- PASS: TestConformance (14.37s)
    --- SKIP: TestConformance/GatewayFollowingEPPRouting (0.00s)
    --- SKIP: TestConformance/HTTPRouteInvalidInferencePoolRef (0.00s)
    --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools (8.14s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Primary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (6.96s)
        --- PASS: TestConformance/HTTPRouteMultipleGatewaysDifferentPools/Secondary_HTTPRoute,_InferencePool,_and_Gateway_path:_verify_status_and_traffic (0.45s)
    --- SKIP: TestConformance/InferencePoolAccepted (0.00s)
    --- SKIP: TestConformance/InferencePoolHTTPRoutePortValidation (0.00s)
    --- SKIP: TestConformance/InferencePoolInvalidEPPService (0.00s)
    --- SKIP: TestConformance/HTTPRouteMultipleRulesDifferentPools (0.00s)
    --- SKIP: TestConformance/InferencePoolResolvedRefsCondition (0.00s)
PASS
ok      sigs.k8s.io/gateway-api-inference-extension/conformance 14.587s

netlify · 2025-05-15T17:54:52Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`0b94f9f`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6859a82990297400089b6aab
😎 Deploy Preview	https://deploy-preview-838--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-05-15T17:54:56Z

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

spencerhance · 2025-05-16T18:16:20Z

/cc

spencerhance

/lgtm

conformance/conformance.go

spencerhance · 2025-05-19T18:22:08Z

/lgtm

ahg-g · 2025-05-20T15:14:53Z

/ok-to-test

SinaChavoshi · 2025-06-20T18:54:03Z

https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/838/files#r2150419700 needs to be resolved before merging.

/hold

sorry was waiting for #982 to merge, this makes the code much simpler as all tests now share the EPP and inferencePool definitions from manifests.yaml

robscott

Thanks @SinaChavoshi! This mostly LGTM

conformance/utils/config/timing.go

conformance/utils/traffic/traffic.go

conformance/tests/basic/httproute_multiple_gateways_different_pools.go

conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml

conformance/utils/config/timing.go

conformance/utils/traffic/traffic.go

zetxqx · 2025-06-23T18:15:13Z

/lgtm

thanks!

cc @danehans @robscott could you take another look? Thanks!

robscott

Thanks @SinaChavoshi!

/lgtm

danehans · 2025-06-23T20:33:24Z

@SinaChavoshi thanks for all your work and patience with this PR.

/approve

k8s-ci-robot · 2025-06-23T20:33:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, robscott, SinaChavoshi, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danehans]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SinaChavoshi · 2025-06-23T20:52:00Z

/unhold

…ubernetes-sigs#838) * copy of accepted inference pool test to start from. * add yaml file for the test * update time out * update the yaml file to add port 9002 * read timeout config from local repo * remove excess comments * copy from existing test to start with * update test and add gateway to main manifest * fix spelling error * correct spelling for scenarios * check route condition on RouteConditionResolvedRefs * check RouteConditionResolvedRefs instead of Reconciled * remove empty lines in yaml * set optional/defaulted fields as unspecified * add new line at the end of yaml files. * delete blank lines in yaml files. * change variable names to use primary / secondary * add to do for name change across the project. * fix comment * change all variable names to use primary/secondary consistantly * add to do for http route testing * HTTPRouteMustBeAcceptedAndResolved * add helper method. * using helper method for pool route accepted. * combline pool and route accpetnace * add http route validation * remove extra comments and yaml fields. * remove duplicate method * fix timeout * fix timeout * change varialbe names to use primary secondary consistently. * remove extra comments * factor out common code * Add actual http traffic validation using echo-basic * remove extra comments from manifest * remove modifiedTimeoutConfig.HTTPRouteMustHaveCondition per review comment. * remove modifiedTimeoutConfig.HTTPRouteMustHaveCondition per review comment * remove excessive logging from conformance.go * Update conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml Co-authored-by: Lior Lieberman <[email protected]> * Update conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml Co-authored-by: Lior Lieberman <[email protected]> * Update conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml Co-authored-by: Lior Lieberman <[email protected]> * Update conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml Co-authored-by: Lior Lieberman <[email protected]> * Update conformance/tests/basic/httproute_multiple_gateways_different_pools.yaml Co-authored-by: Lior Lieberman <[email protected]> * Remove unecessary logs for accpeted reason. * Remove all comments from yaml and go files and fix yaml * intermediate update * fix the test run * factor out common code * move epp def to shared manifest * remove extra comments * revert back to two epps * update to use epp filter * remove extra comments * add to do for epp image * switch to GeneralMustHaveConditionTimeout * undo gateway version changes * remove unused HTTPRouteMustHaveConditions * update doc string for GetPod * update docstring * fix defaults in timing.go * Remove resource type from names in manifests. * remove type from name * remove health check * add todo for combining getpod methods * remove duplicate methods * revert changes to conformance.go * revert chagnes to conformance.go * revert changes to helpers.go * use epp and pool from shared manifest * add todo to factor out common constants * remove port number for EPP call * remove port number for inf pool ref * use GetPodsWithLabel * removed unused method * fix routing issue * switch to using MakeRequestAndExpectEventuallyConsistentResponse * undo changes to GatewayFollowingEPPRouting * revert changes to traffic.go --------- Co-authored-by: Lior Lieberman <[email protected]>

SinaChavoshi added 8 commits May 14, 2025 20:30

copy of accepted inference pool test to start from.

87d1756

add yaml file for the test

a9dcb62

update time out

c36e5f8

update the yaml file to add port 9002

aaf23e2

read timeout config from local repo

2a67e7d

remove excess comments

8ac7d72

copy from existing test to start with

c859896

update test and add gateway to main manifest

fe540a7

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 15, 2025

k8s-ci-robot requested review from nirrozenbaum and robscott May 15, 2025 17:54

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2025

k8s-ci-robot requested a review from spencerhance May 16, 2025 18:16

spencerhance approved these changes May 16, 2025

View reviewed changes

conformance/conformance.go Outdated Show resolved Hide resolved

k8s-ci-robot assigned spencerhance May 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2025

fix spelling error

63fedab

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025

SinaChavoshi added 3 commits May 20, 2025 17:02

correct spelling for scenarios

66f325d

check route condition on RouteConditionResolvedRefs

fd0fa10

check RouteConditionResolvedRefs instead of Reconciled

68812d7

add todo to factor out common constants

be03841

SinaChavoshi mentioned this pull request Jun 20, 2025

Conformance: Drop the resource type as a suffix from resource names #1030

Open

robscott reviewed Jun 20, 2025

View reviewed changes

conformance/utils/config/timing.go Outdated Show resolved Hide resolved

conformance/utils/traffic/traffic.go Outdated Show resolved Hide resolved

conformance/tests/basic/httproute_multiple_gateways_different_pools.go Outdated Show resolved Hide resolved

zetxqx reviewed Jun 20, 2025

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2025

SinaChavoshi mentioned this pull request Jun 23, 2025

Conformance: Refactor Timeout Configuration for Test Suite to allow values set via flag #1048

Open

Merge remote-tracking branch 'upstream' into inf_pool_tests_12

7a9133c

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2025

SinaChavoshi added 4 commits June 23, 2025 17:00

remove port number for EPP call

810e055

remove port number for inf pool ref

17ab77b

use GetPodsWithLabel

fbce2d5

removed unused method

af6b681

SinaChavoshi added 4 commits June 23, 2025 18:17

fix routing issue

22bf7f9

switch to using MakeRequestAndExpectEventuallyConsistentResponse

d491509

undo changes to GatewayFollowingEPPRouting

413ec25

revert changes to traffic.go

0b94f9f

robscott approved these changes Jun 23, 2025

View reviewed changes

k8s-ci-robot assigned robscott Jun 23, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025

k8s-ci-robot merged commit 64c62ad into kubernetes-sigs:main Jun 23, 2025
9 checks passed

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

feat(conformance): Add HTTPRouteMultipleGatewaysDifferentPools test #838

Uh oh!

Conversation

SinaChavoshi commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

k8s-ci-robot commented May 15, 2025

Uh oh!

spencerhance commented May 16, 2025

Uh oh!

spencerhance left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spencerhance commented May 19, 2025

Uh oh!

ahg-g commented May 20, 2025

Uh oh!

SinaChavoshi commented Jun 20, 2025

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zetxqx commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robscott left a comment

Choose a reason for hiding this comment

Uh oh!

danehans commented Jun 23, 2025

Uh oh!

k8s-ci-robot commented Jun 23, 2025

Uh oh!

SinaChavoshi commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

SinaChavoshi commented May 15, 2025 •

edited

Loading

netlify bot commented May 15, 2025 •

edited

Loading

zetxqx commented Jun 23, 2025 •

edited

Loading